1683424 - The aspect ratio used in ComputeSizeWithIntrinsicDimensions() should consider box-sizing if it is from aspect-ratio property

Status: RESOLVED FIXED

(Core :: Layout, defect, P3)

Description

[Boris Chiou [:boris]]

Based on the spec definitions, for replaced elements, if aspect-ratio is:

1. auto
   Replaced elements with a natural aspect ratio use that aspect ratio; otherwise the box has no preferred aspect ratio. Size calculations involving the aspect ratio work with the content box dimensions always.

2. <ratio>
   The box’s preferred aspect ratio is the specified ratio of width / height. Size calculations involving the aspect ratio work with the dimensions of the box specified by box-sizing.

3. auto && <ratio>
   If both auto and a <ratio> are specified together, the preferred aspect ratio is the specified ratio of width / height unless it is a replaced element with a natural aspect ratio, in which case that aspect ratio is used instead. In all cases, size calculations involving the aspect ratio work with the content box dimensions always.

So if we use <ratio>, we have to take box-sizing into consideration for replaced elements.

Comment 1

[Boris Chiou [:boris]]

Attachment: Bug 1683424 - Add UseBoxSizing for AspectRatio class, and fix non-replaced element usage.

In some cases, the aspect ratio works with box sizing dimensions, and
sometimes it works only with content box dimensions. We need an extra
flag to know this, and handle it well while computing the size in
ratio-dependent axis.

Comment 2

[Boris Chiou [:boris]]

Attachment: Bug 1683424 - Take box sizing into account for replaced elements with aspect-ratio.

If aspect-ratio is '<ratio>', now the aspect-ratio works with box sizing
dimensions for replaced elements.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c86f4e7967e3
Add UseBoxSizing for AspectRatio class, and fix non-replaced element usage. r=TYLin
https://hg.mozilla.org/integration/autoland/rev/5dc148186bb2
Take box sizing into account for replaced elements with aspect-ratio. r=TYLin

Comment 4

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/27008 for changes under testing/web-platform/tests

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/c86f4e7967e3
https://hg.mozilla.org/mozilla-central/rev/5dc148186bb2

Comment 6

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot