Closed Bug 1684107 Opened 4 years ago Closed 8 months ago

Make sure we take box-sizing into account when using AspectRatio for all replaced elements

Categories

(Core :: Layout, defect, P3)

Product:
Core
Component:
Layout
Type:
defect

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: boris, Unassigned)

References

(Blocks 1 open bug)

Details

Bug 1683424 updated AspectRatio and we should always use ComputeRatioDependentSize() to get the transferred size for both replaced and non-replaced elements. Besides, ApplyTo() should go private if possible.

We've used ComputeRatioDependentSize() in nsContainerFrame::ComputeSizeWithIntrinsicDimensions(). Therefore, when computing the size for replaced elements, box-sizing should have been considered.

Some callers still use AspectRatio::ApplyTo() to deal with image intrinsic ratio, so ApplyTo() cannot be private.

Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.