1683434 - Additional UX improvements

Status: RESOLVED FIXED

(Tree Management :: Push Health, enhancement)

Description

[Sarah Clements [:sclements]]

A few more details we need to iron out based on a recent demo to a user who hadn't seen the new Push Health changes:

• Push Usage - this was confusing for the user because he wasn't sure what it was for and how it'd be relevant to him/his pushes. Joel, Cam, is this something that is being used? Can this be hidden from the main menu?

• Regarding the Push <sha>... on <repo in the Commit Header, it should not be shortened in case someone wants to search by commit in the My Pushes view and when clicking on that link, it would be more intuitive for it to go to the push-health/push view rather than the jobs view. Perhaps we keep it as-is in the individual push view or use a link icon for it to go to that push in the jobs view.

• Need to add additional media query for My Pushes for smaller laptop size.

• It's not intuitive how to get to Push Health from the jobs view - the user wanted to click on health (however, he had good things to say about the revamped push health summary link on try pushes).

• Don't show the artifacts tab if there aren't any and make that font size match the failure lines tab.

• Build and lint failures should also have task buttons that show the details panel (failure lines and artifacts) like the test tab does (instead of linking back to the treeherder jobs view)

Plus, this change that wasn't addressed in bug 1678763:

• If a user is logged out and they have selected an action, they should be logged in and the action performed (this has been done for taskcluster actions in the jobs view).

Comment 1

[Sarah Clements [:sclements]]

Also, a bug I noticed is that if you select a task in Push Health, the url is updated with that query param so its shareable. However, if you close that task the query param isn't removed.

Comment 2

[Sarah Clements [:sclements]]

Anny, there was an item that I didn't get to yet (from when you gave us feedback on Push Health recently) that I want to clarify because I don't quite understand my own notes :)

You said something about structured logging doesn't exist so it makes the results contradictory and the user has to go to the jobs view. Could you clarify what you meant? Maybe add a screenshot or two?

Comment 3

[Cameron Dawson [:camd]]

(In reply to Sarah Clements [:sclements] from comment #0)

A few more details we need to iron out based on a recent demo to a user who hadn't seen the new Push Health changes:

• Push Usage - this was confusing for the user because he wasn't sure what it was for and how it'd be relevant to him/his pushes. Joel, Cam, is this something that is being used? Can this be hidden from the main menu?

Yeah, I think it can be hidden in some way. Maybe have a discreen "ADMIN" or "STATS" button somewhere on Push Health. Maybe a gear drop-down on the right side?

Comment 4

[Sarah Clements [:sclements]]

Per a comment from Anny in-channel, I think I confused the structured logging statement with something Cam said about something else entirely, so disregarding that.

Comment 5

[Sarah Clements [:sclements]]

Link to logviewer is broken when you click onto it from the details panel: http://localhost:5000/push-health/logviewer?job_id=327721110&repo=try&lineNumber=6558

Should remove the push-health route.

Comment 6

[Sarah Clements [:sclements]]

To recap what I mentioned in the video call - iam/auth0 has a separate authentication flow used for our user table and session management. The taskcluster login is a separate authorization code flow used to retrieve credentials for a user (using their iam/auth0 username to retrieve their tc scope).

Here's the component that is rendered when someone clicks on the Login button: https://github.com/mozilla/treeherder/blob/master/ui/login-callback/LoginCallback.jsx, and once the auth0 access token is retrieved it checks for taskcluster credentials (line 43).

There's a ui/helpers/taskcluster file for initiating that check, and a TaskclusterCallback component. Within the taskcluster helper file, we have a debounced method used for when someone wants to perform an action (say a retriger). We check credentials, if they have expired, go through the taskcluster auth flow with enough time in the setTimeout to then check for the credentials and perform the action: https://github.com/mozilla/treeherder/blob/master/ui/helpers/taskcluster.js#L86

My thinking is we can do a debounced/timeout operation for the entire auth0 and taskcluster check or auth flow in push health (for whenever someone retriggers or marks something as investigated).

Comment 7

[[e-mail] (:bhearsum)]

(Adding a user story with a summary of all of the issues)

Comment 8

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/6998

Comment 9

[Sarah Clements [:sclements]]

The three things left to do that were not included in Ben's pr are:

• Need to add additional media query for My Pushes for smaller laptop size.
• Build and lint failures should also have task buttons that show the details panel (failure lines and artifacts) like the test tab does (instead of linking back to the treeherder jobs view)
• If a user is logged out and they have selected an action, they should be logged in and the action performed (this has been done for taskcluster actions in the jobs view).

Comment 10

[Sarah Clements [:sclements]]

Two new bugs:

• a 500 error is hit when selecting push health from here (jmaher mentioned this could be because we could have code in-tree that landed on mozilla-central to change output which never made it to esr)
• Greg tatum mentioned that the push health summary was showing builds and linting as passing before they’ve even run - think that must be a regression and need to add additional test cases

Comment 11

[Sarah Clements [:sclements]]

Attachment: Screen Shot 2021-02-25 at 12.13.46 PM.png

Another little bug - pie chart color should be green, not red.

Comment 12

[Sarah Clements [:sclements]]

And look into the back navigation from my pushes -> push health for individual repo -> click on builds or tests tab -> press back (one user needed to click back multiple times).

Comment 13

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/7110