1683487 - Mouse-wheel scroll stopped working in browserAction popup with WebRender

Status: RESOLVED FIXED

(WebExtensions :: General, defect, P2)

Description

[erosman]

Since the last 2-3 upgrade (AFAIK), the mouse-wheel scroll stopped working in the browser Action popup on windows.

Additionally, installed and tested with "Multi-Account Containers" to verify the issue is not limited to a particular WebExtension.

After checking with #nightly:mozilla.org it seems there is no problem on Linux.

I am not able to use mozregression as it doesn't work on win7.

Note: mouse-wheel scroll works fine in bookmarks popup.

Comment 1

[Shane Caraveo (:mixedpuppy)]

(In reply to erosman from comment #0)

Since the last 2-3 upgrade (AFAIK), the mouse-wheel scroll stopped working in the browser Action popup on windows.

By 2-3 upgrades, is this nightly or something else?

Waiting for regression test from QA

Comment 2

[Alice0775 White]

Steps:

1. install https://addons.mozilla.org/en-US/firefox/addon/multi-account-containers/
2. Click on toolbutton of the addon
3. Click "Manage Containers" at bottom of arrow panel
4. Create several containers so that scroll bar will appear
5. Try scroll the list with mouse Wheel

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=8c8bbc19e7f90f621bc92f805db1fddcdad605b4&tochange=d8bd960f9b82ca8d9ef340ae488673b6f0c0669e

Comment 3

[erosman]

By 2-3 upgrades, is this nightly or something else?

Nightly Indeed .... bug version is also set to Firefox 86

Comment 4

[Hiroyuki Ikezoe (:hiro)]

erosma, thanks for reporting this issue! We have a similar report (bug 1683612), but it's scrollable, the scrollbar doesn't appear, is your issue different? not scrollable?

Comment 5

[erosman]

Attachment: popup.png

Comment 6

[erosman]

the scrollbar doesn't appear, is your issue different? not scrollable?

In this case, the scrollbar appears but does not scroll with mouse-wheel on Windows 7.

Comment 7

[Hiroyuki Ikezoe (:hiro)]

Thanks! That's weird, it sounds an opposed behavior. :/

Comment 8

[Alice0775 White]

I can aloso reproduce the issue on Windows10.

Comment 9

[Hiroyuki Ikezoe (:hiro)]

Thank you, Alice now I confirmed it on my Windows 10 laptop as well, but it looks like this is WebRender specific.

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1493208

Comment 11

[Hiroyuki Ikezoe (:hiro)]

I just realized that keyboard scrolling works fine.

Comment 12

[Hiroyuki Ikezoe (:hiro)]

ScrollMetadata.mLineScrollAmount is (0, 0) on Windows for some reasons, thus mouse wheel delta is calculated (0, 0), which means user can't scroll by mouse wheel.

Though I am not 100% sure, it seems this SetScrollLineAmount isn't called.

Comment 13

[Hiroyuki Ikezoe (:hiro)]

While I was in a rabbit hole to try to find out where the (0, 0) line scroll amount comes from, kats told me on Matrix that using gfxVars::UseWebRender() might be causing this problem such as a check in APZCTreeManager::GetTargetAPZC. The part is actually the culprit of this issue.

We should (probably) fix other places where we use gfxVars::UseWebRender(), I will file bugs for them.

Comment 14

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1683487 - Use GetAPZCAtPointWR depending on whether the corresponding window uses WebRender instead of the preference value. r?botond

Comment 15

[Hiroyuki Ikezoe (:hiro)]

Probably I could add a test for the change, will try it later.

Comment 16

[Danny Colin [:sdk]]

(In reply to erosman from comment #0)

After checking with #nightly:mozilla.org it seems there is no problem on Linux.

I can reproduce it on Linux with WebRender.

Comment 17

[Hiroyuki Ikezoe (:hiro)]

(In reply to Danny Colin [:sdk] from comment #16)

(In reply to erosman from comment #0)

After checking with #nightly:mozilla.org it seems there is no problem on Linux.

I can reproduce it on Linux with WebRender.

Because of this restriction.

Comment 21

[Hiroyuki Ikezoe (:hiro)]

Given that there are a bunch of bug reports on this issue, I will land attachment #9194620 [details] even though unfortunately the test in the change doesn't work properly on Mac OS because nsIDOMWindowUtils.sendNativeMouseScrollEvent doesn't work properly for popup windows on Mac. I am going to skip the test on Mac and will file a follow up bug to enable the test on Mac.

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/01bc787e90de
Use GetAPZCAtPointWR depending on whether the corresponding window uses WebRender instead of the preference value. r=botond

Comment 24

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/01bc787e90de

Comment 25

[erosman]

I can confirm, on 86.0a1 (2021-01-06) (64-bit) Windows 7, Mouse-wheel scroll is working again.

Comment 26

[Tomislav Jovanovic :zombie]

(In reply to Hiroyuki Ikezoe (:hiro) from comment #21)

Given that there are a bunch of bug reports on this issue, I will land attachment #9194620 [details] even though unfortunately the test in the change doesn't work properly on Mac OS because nsIDOMWindowUtils.sendNativeMouseScrollEvent doesn't work properly for popup windows on Mac. I am going to skip the test on Mac and will file a follow up bug to enable the test on Mac.

Thanks Hiro!

Based on bug 1684445 I think you could add a click test (instead of scrolling) that should cover Mac as well.