1684011 - remove MailGlue _legacyCheck()

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, task)

Description

[Magnus Melin [:mkmelin]]

+++ This bug was initially created as a clone of Bug #1661216 +++

See bug 1661216 comment 4.
_legacyCheck() and related code was only needed for the 68->78 upgrade. We can remove it now and save a tiny bit on startup time.

https://searchfox.org/comm-central/rev/94587d2bae3c1343918eecc9008cea105f54a47a/mail/components/MailGlue.jsm#323

Comment 1

[John Bieling]

With only 4% using TB68, this is probably a good thing to do. Nevertheless - if you agree - I would like to add a notification to such add-ons installed in TB78, that they are not supported (because there is no other hint in the UI currently).

That notification would be just part of the add-on manager UI and not of any start-up code.

Comment 2

[Magnus Melin [:mkmelin]]

According to the original bug, they can't be installed in 78 at all. It was just added for the upgrade scenario, no?

Comment 3

[John Bieling]

Many users still install add-ons via file install and if a legacy WebExtension does not have a max version setting, it will install without error. The startup check disabled these add-ons on next restart. This will no longer work and those add-ons will just sit there being properly installed without doing anything.

Comment 4

[John Bieling]

Attachment: bug1684011_remove_legacy_check.patch

Comment 5

[Magnus Melin [:mkmelin]]

Comment on attachment 9199516 [details] [diff] [review]
bug1684011_remove_legacy_check.patch

Review of attachment 9199516 [details] [diff] [review]:
-----------------------------------------------------------------

Great, thx! r=mkmelin

Comment 6

[Worcester12345]

Is there any specific version, platform, priority? Thanks.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d3e7a67ff191
remove MailGlue _legacyCheck(). r=mkmelin