1688904 - Prevent add-ons using the legacy API from installing

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, enhancement)

Description

[John Bieling (:TbSync)]

In preparation to remove the legacy check (bug 1684011), I found a nice way to prevent legacy webextensions (using the deprecated legacy API) from installing.

Comment 1

[John Bieling (:TbSync)]

Attachment: bug1688904_prevent_legacy_addons_from_installing.patch

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9199286 [details] [diff] [review]
bug1688904_prevent_legacy_addons_from_installing.patch

Review of attachment 9199286 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin

Comment 3

[Worcester12345]

Is there a version associated with this? Thanks.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0fb3daf57a2d
Prevent add-ons still using the legacy API from installing. r=mkmelin

Comment 5

[John Bieling (:TbSync)]

Comment on attachment 9199286 [details] [diff] [review]
bug1688904_prevent_legacy_addons_from_installing.patch

[Approval Request Comment]
When TB78 was released I did not yet know about the approach I used in this
patch and failed to implement a proper way to prevent legacy add-ons from
installing (see bug 1661216 Comment 17).

Regression caused by (bug #):
User impact if declined:
Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky):
None.

Comment 6

[John Bieling (:TbSync)]

Comment on attachment 9199286 [details] [diff] [review]
bug1688904_prevent_legacy_addons_from_installing.patch

[Approval Request Comment]
When TB78 was released I did not yet know about the approach I used in this
patch and failed to implement a proper way to prevent legacy add-ons from
installing (see bug 1661216 Comment 17).

Regression caused by (bug #):
User impact if declined:
Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky):
None.

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9199286 [details] [diff] [review]
bug1688904_prevent_legacy_addons_from_installing.patch

[Triage Comment]
Approved for esr78. Note, didn't go through beta yet, which is OK - taking on beta at same time

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 78.7.1:
https://hg.mozilla.org/releases/comm-esr78/rev/09299b980332

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9199286 [details] [diff] [review]
bug1688904_prevent_legacy_addons_from_installing.patch

[Triage Comment]
Approved for beta

Comment 10

[Rob Lemley [:rjl]]

Thunderbird 86.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/727871d53ffc