Closed Bug 1688904 Opened 3 years ago Closed 3 years ago

Prevent add-ons using the legacy API from installing

Categories

(Thunderbird :: Add-Ons: Extensions API, enhancement)

Thunderbird 87
enhancement

Tracking

(thunderbird_esr78+ fixed, thunderbird86+ fixed)

RESOLVED FIXED
87 Branch
Tracking Status
thunderbird_esr78 + fixed
thunderbird86 + fixed

People

(Reporter: TbSync, Assigned: TbSync)

References

Details

Attachments

(1 file)

In preparation to remove the legacy check (bug 1684011), I found a nice way to prevent legacy webextensions (using the deprecated legacy API) from installing.

Attachment #9199286 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9199286 [details] [diff] [review]
bug1688904_prevent_legacy_addons_from_installing.patch

Review of attachment 9199286 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin
Attachment #9199286 - Flags: review?(mkmelin+mozilla) → review+

Is there a version associated with this? Thanks.

Version: unspecified → Thunderbird 87

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/0fb3daf57a2d
Prevent add-ons still using the legacy API from installing. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Flags: needinfo?(john)

Comment on attachment 9199286 [details] [diff] [review]
bug1688904_prevent_legacy_addons_from_installing.patch

[Approval Request Comment]
When TB78 was released I did not yet know about the approach I used in this
patch and failed to implement a proper way to prevent legacy add-ons from
installing (see bug 1661216 Comment 17).

Regression caused by (bug #):
User impact if declined:
Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky):
None.

Attachment #9199286 - Flags: approval-comm-esr78?

Comment on attachment 9199286 [details] [diff] [review]
bug1688904_prevent_legacy_addons_from_installing.patch

[Approval Request Comment]
When TB78 was released I did not yet know about the approach I used in this
patch and failed to implement a proper way to prevent legacy add-ons from
installing (see bug 1661216 Comment 17).

Regression caused by (bug #):
User impact if declined:
Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky):
None.

Flags: needinfo?(john)
Attachment #9199286 - Flags: approval-comm-beta?
Target Milestone: --- → 87 Branch

Comment on attachment 9199286 [details] [diff] [review]
bug1688904_prevent_legacy_addons_from_installing.patch

[Triage Comment]
Approved for esr78. Note, didn't go through beta yet, which is OK - taking on beta at same time

Attachment #9199286 - Flags: approval-comm-esr78? → approval-comm-esr78+

Comment on attachment 9199286 [details] [diff] [review]
bug1688904_prevent_legacy_addons_from_installing.patch

[Triage Comment]
Approved for beta

Attachment #9199286 - Flags: approval-comm-beta? → approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: