1684054 - Remove unused focus argument from "WebDriver:SwitchToFrame"

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Since this command has been ported over to JSWindowActors the focus argument is no longer handled.

Here the code from before:
https://searchfox.org/mozilla-central/rev/38ed718a101aca27db25984413c052ccd8c0ceda/testing/marionette/driver.js#1921-1923
https://searchfox.org/mozilla-central/rev/38ed718a101aca27db25984413c052ccd8c0ceda/testing/marionette/listener.js#796-798

Now we would only have to handle it in:
https://searchfox.org/mozilla-central/rev/38ed718a101aca27db25984413c052ccd8c0ceda/testing/marionette/actors/MarionetteCommandsChild.jsm#492

It would be good to know why some of the Marionette unit tests for focus don't fail. Or maybe we don't have any?

Note that this is a non-standard argument and as such I don't think we have to uplift the patch to 85.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Even with Marionette client defaulting to true for focus, it's actually never missed by any Marionette test. Probably it also doesn't make sense, and is a no-op. As such I would suggest that we remove the argument.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1684054 - [marionette] Remove unused focus argument from "WebDriver:SwitchToFrame".

Comment 3

[Chris Peterson [:cpeterson]]

Tracking marionette-fission-reserve bugs for Fission MVP

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/70dc2d92d90e
[marionette] Remove unused focus argument from "WebDriver:SwitchToFrame". r=marionette-reviewers,jdescottes

Comment 5

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/70dc2d92d90e

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:whimboo, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.