Closed Bug 1685301 Opened 4 years ago Closed 4 years ago

remove default XUL namespace from Thunderbird CSS

Categories

(Thunderbird :: Theme, task)

Product:
Thunderbird
Component:
Theme
Type:
task

Tracking

(thunderbird_esr78 wontfix, thunderbird85 wontfix)

Status:
RESOLVED FIXED
Milestone:
86 Branch
Tracking Flags:
Tracking Status
thunderbird_esr78 --- wontfix
thunderbird85 --- wontfix

People

(Reporter: mkmelin, Assigned: mkmelin)

References

Details

Attachments

(1 file)

bug1685301_no_xul_css_namespace.patch
27.64 KB, patch
Paenglab
: review+
Details | Diff | Splinter Review

As seen in bug 1572062, having the default XUL namespace in some CSS files can cause some surprises as we move towards (X)HTML.

They are not really needed, so let's removed them across the codebase.

I don't see any problems removing these.

Attachment #9195636 - Flags: review?(richard.marti)
Status: NEW → ASSIGNED
Comment on attachment 9195636 [details] [diff] [review] bug1685301_no_xul_css_namespace.patch Review of attachment 9195636 [details] [diff] [review]: ----------------------------------------------------------------- I have only roughly checked on Windows if I see something weird. All was looking good (not expected different). ::: mail/themes/linux/mail/accountWizard.css @@ +11,1 @@ > You could delete one empty line. ::: mail/themes/linux/mail/addrbook/abContactsPanel.css @@ +11,1 @@ > Here too. And on almost every file.
Attachment #9195636 - Flags: review?(richard.marti) → review+

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/db5c5b21518f
remove default XUL namspace from CSS to avoid suripses when moving to (x)html. r=Paenglab

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
status-thunderbird85: --- → wontfix
status-thunderbird_esr78: --- → wontfix
See Also: → messenger.xhtml
Target Milestone: --- → 86 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: