Use html root element in messenger.xhtml and update styling to support html roots
Categories
(Thunderbird :: General, task, P2)
Tracking
(thunderbird_esr78 wontfix, thunderbird85 wontfix)
People
(Reporter: mkmelin, Assigned: mkmelin)
References
(Blocks 1 open bug)
Details
Attachments
(2 files, 3 obsolete files)
|
48.20 KB,
patch
|
Details | Diff | Splinter Review | |
|
20.44 KB,
patch
|
darktrojan
:
review+
|
Details | Diff | Splinter Review |
The messenger.xhtml bug mirroring bug 1492582.
This will make messenter.xhtml use a top level <html> tag with <head> and <body>.
|
Assignee | |
Comment 1•4 years ago
|
||
This should be it. Everything seems to look like it did.
The one problem I've noticed is that in dark mode the quick filter bar is not dark.
|
||
Comment 2•4 years ago
|
||
Comment on attachment 9194866 [details] [diff] [review]
bug1572062_messenger_html_root.patch
(In reply to Magnus Melin [:mkmelin] from comment #1)
Created attachment 9194866 [details] [diff] [review]
bug1572062_messenger_html_root.patchThis should be it. Everything seems to look like it did.
The one problem I've noticed is that in dark mode the quick filter bar is not dark.
It seems that with this patch mailWindow1.css does no more apply on the QFB. Moving https://searchfox.org/comm-central/source/mail/themes/shared/mail/mailWindow1.css#97-124 to the shared messenger.css works for me. Maybe you could combine the rules with the ones here: https://searchfox.org/comm-central/source/mail/themes/shared/mail/messenger.css#191.
With drawInTitlebar the window buttons (Minimize/Maximize/Close) are always on the left side.
|
|
||
Comment 3•4 years ago
|
||
|
|
Assignee | |
Comment 4•4 years ago
|
||
Ah, thanks for the hint! mailWindow1.css had a default xul namespacing which messed things up. We should probably get rid of (almost?) all of those.
Without the <box> it doesn't work for me, the layout is quite borked.
|
|
Assignee | |
Comment 5•4 years ago
|
||
|
|
||
Comment 6•4 years ago
|
||
The messageheader are also not dark in main window. Maybe the same issue on messageHeader.css.
|
|
Assignee | |
Comment 7•4 years ago
|
||
Indeed, same issue there. Removing the default xul namespace from messageHeader.css fixes it.
If you had something without <box> that worked, what was it? Can you send that diff?
|
|
||
Comment 8•4 years ago
|
||
This works for me on Windows. Need to test on other platforms.
|
|
||
Comment 9•4 years ago
|
||
Missed the hiddenWindowMac.xhtml.
|
|
Assignee | |
Comment 10•4 years ago
|
||
Yes, that does seem to work! I don't know why it didn't when I tried earlier.
|
|
||
Updated•4 years ago
|
|
|
||
Comment 11•4 years ago
|
||
Comment on attachment 9194890 [details] [diff] [review]
bug1572062_messenger_html_root.patch
I tested with my patch but I can't approve my own changes. Please test my patch and when it's OK use it to land. I tried my patch on all platforms and I saw no regressions. It should work as before.
|
|
Assignee | |
Comment 12•4 years ago
|
||
Excellent, thank you very much for the help!
|
|
Assignee | |
Updated•4 years ago
|
|
||
Comment 13•4 years ago
|
||
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/90c67dcde6a4
Use html root element in messenger.xhtml and update styling to support html roots. r=Paenglab
|
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 14•4 years ago
|
||
A slight followup: <script> should not use minimized form even in XHTML, even if it works.
|
||
Comment 15•4 years ago
|
||
Comment on attachment 9195292 [details] [diff] [review]
bug1572062_close_script.patch
LGTM.
|
|
||
Updated•4 years ago
|
|
|
||
Comment 16•4 years ago
|
||
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/231fed6a1613
<script> should not use minimized form in xhtml. r=darktrojan
Description
•