1685411 - Re-enable devtools/client/debugger/test/mochitest/browser_dbg-bfcache.js test for Fission

Status: RESOLVED DUPLICATE of bug 1694651

(DevTools :: Debugger, defect, P3)

Description

[Chris Peterson [:cpeterson]]

This devtools/client/debugger/test/mochitest/browser_dbg-bfcache.js test is currently skipped for Fission (by bug 1665165):

[browser_dbg-bfcache.js]
skip-if = fission # bug 1665165

https://searchfox.org/mozilla-central/rev/ef900cd2258d4c5d968093f612f807d96e6e7c98/devtools/client/debugger/test/mochitest/browser.ini#217-218

Is this test still failing with Fission?
Does fixing and re-enabling this test need to block shipping Fission MVP?

Comment 1

[Chris Peterson [:cpeterson]]

Tracking DevTools Fission bugs for Fission M7 (blocking Beta experiment).

Comment 2

[Julian Descottes [:jdescottes]]

Seems to work locally when enabling fission? Let's check on try: https://treeherder.mozilla.org/jobs?repo=try&revision=48248c5936c2a0c5b5a1e9c11f711c8d0fff0b65

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1685411 - [devtools] Re-enable browser_dbg-bfcache.js test for Fission

Comment 4

[Julian Descottes [:jdescottes]]

smaug: quick sanity check, this test was disabled as part of bfcache work, in bug 1665165.
You're still working on bfcache, so I'm not sure if we can re-enable the tests (it seems to pass fine with fission?) or if we should wait?

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

bfcache work has started quite recently, so we can't enable the test yet.
Also, most of the bfcache tests will need some tweaking to work with the new implementation.

Comment 6

[Julian Descottes [:jdescottes]]

Will un-assign and remove the patch for now.

Comment 7

[Julian Descottes [:jdescottes]]

smaug: Thanks for the info. Is there a bug we can block this on?

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

This is already blocking fission-bfcache

Comment 9

[Julian Descottes [:jdescottes]]

This is already blocking fission-bfcache

I saw that but my question was the other way around :)

We want to know when we can start working on this bug.
Right now it's in our backlog for fission, but not actionable.

Otherwise we just remove this from the devtools backlog, feels like it can't be addressed & triaged by our team.

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

Removing from devtools backlog does sound reasonable at this point, given that the test itself is rather simple.

Comment 12

[Neha Kochar [:neha]]

Honza said this is not part of dt-fission-m3-mvp and is not considered Fission M7 blocker.

Comment 13

[Chris Peterson [:cpeterson]]

dt-fission-future don't need to block Fission MVP.

Comment 14

[Neha Kochar [:neha]]

Fission Future should be used for stuff that aren't issues for Fission. So bringing this back into MVP.

Comment 15

[Chris Peterson [:cpeterson]]

dt-fission-future bugs don't need to block Fission MVP, so I'm moving them from Fission Milestone MVP to Future.

Comment 16

[Alexandre Poirot [:ochameau]]

I'm most likely going to fix and renable this test in bug 1694651, with https://phabricator.services.mozilla.com/D110557

Comment 17

[Neha Kochar [:neha]]

Got re-enabled in bug 1694651.