Closed Bug 1685628 Opened 3 years ago Closed 3 years ago

Fix common.css radio button hover styles to be consistent with checkboxes

Categories

(Toolkit :: Themes, defect)

defect

Tracking

()

VERIFIED FIXED
86 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox84 --- unaffected
firefox85 --- unaffected
firefox86 --- verified

People

(Reporter: ntim, Assigned: ntim)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

No description provided.

Set release status flags based on info from the regressing bug 1678333

Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/2a0cf94cd946
Fix common.css radio button hover styles to be consistent with checkboxes. r=dao

Comment on attachment 9195981 [details]
Bug 1685628 - Fix common.css radio button hover styles to be consistent with checkboxes. r=dao,jaws

Beta/Release Uplift Approval Request

  • User impact if declined: Inconsistent hover state between checkboxes and radios on about: pages

  • Is this code covered by automated tests?: No

  • Has the fix been verified in Nightly?: No

  • Needs manual test from QE?: Yes

  • If yes, steps to reproduce:

    • Go to about:preferences
    • Hover checkboxes
    • Hover radio buttons (in the search pane for instance)
  • List of other uplifts needed: None

  • Risk to taking this patch: Low

  • Why is the change risky/not risky? (and alternatives if risky): css fix

  • String changes made/needed: no

Attachment #9195981 - Flags: approval-mozilla-beta?
Flags: qe-verify+
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
QA Whiteboard: [qa-triaged]

Hello,

I'm trying to verify this bug. On Fx Nightly 86.0a1 (from today) I can confirm this issue is fixed on mac OS 10.13, ubuntu 18.04 and Win 10 x64.

But I cant reproduce this issue on Beta 85.0b7, 85.0b6 and 85.0b3. Maybe I have missed something, can you offer some help?

Flags: needinfo?(ntim.bugs)

This is a regression of bug 1679452, sorry about that.

Flags: needinfo?(ntim.bugs)
Regressed by: 1679452
No longer regressed by: 1678333
Has Regression Range: --- → yes
Attachment #9195981 - Flags: approval-mozilla-beta?
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: