1685737 - Blocked mixed content downloads cause us to show the downloads panel until they're removed from history

Status: VERIFIED FIXED

(Core :: DOM: Security, defect, P2)

Description

[:Gijs (he/him)]

STR:

1. macOS or Windows (haven't tested Linux), today's nightly
2. go to https://www.thinkbroadband.com/download
3. click any of the links
4. select "save as" instead of "open"
5. wait for the download panel to show (it might not, bug 1685736)
6. close the panel
7. restart Firefox (either for an update, or just quit it and reopen it)

ER:
the panel does not open up again for the same download

AR:
the panel opens up again

This would get very annoying after a while, and the only workaround appears to be removing the download from your history, by using the context menu or the download manager. A lot of users won't be able to figure this out.

We shouldn't show the panel for downloads that aren't from the current session.

Comment 1

[Nick Alexander :nalexander [he/him]]

I can confirm this on macOS.

Comment 3

[alex_mayorga]

¡Hola y'all!

FWIW updating flags as per Gijs at https://matrix.to/#/!evDrGXhEMVVjldSwGf:mozilla.org/$j4EruFiSrc6DLu7d4lOZN0WhgILeSaL9W7eLoylOpSc?via=mozilla.org&via=matrix.org&via=chat.weho.st this one bite me on 89.

¡Gracias!
Alex

Comment 4

[:Gijs (he/him)]

This is disabled outside of Nightly so updating tracking flags for that...

Comment 6

[Julian Gaibler]

Attachment: WIP: Bug 1685737 - Old blocked mixed-content downloads get removed from download-list on restart.

Comment 7

[Julian Gaibler]

Attachment: Bug 1685737 - Older blocked mixed-content downloads get removed from download-list on restart.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/198b3a144a86
Older blocked mixed-content downloads get removed from download-list on restart. r=Gijs

Comment 9

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/198b3a144a86

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.

Comment 11

[Giorgia Nichita, Release Desktop QA]

Reproduced this issue on an affected Nightly build from 2021-01-08 on Ubuntu 20.04, following the STR from comment 0.

Verified as fixed on Firefox 91.0.2 (20210823123856) across the following platforms: Ubuntu 20.04, Win 10 x64 and macOS 10.15. The download panel does not open up again after a restart or an update.