Closed Bug 1685737 Opened 2 years ago Closed 1 year ago

Blocked mixed content downloads cause us to show the downloads panel until they're removed from history

Categories

(Core :: DOM: Security, defect, P2)

Desktop
All
defect

Tracking

()

VERIFIED FIXED
91 Branch
Tracking Status
firefox86 --- disabled
firefox87 --- disabled
firefox88 --- disabled
firefox89 --- disabled
firefox90 --- disabled
firefox91 --- verified

People

(Reporter: Gijs, Assigned: julianwels)

References

(Blocks 1 open bug)

Details

(Whiteboard: [domsecurity-active])

Attachments

(1 file, 1 obsolete file)

STR:

  1. macOS or Windows (haven't tested Linux), today's nightly
  2. go to https://www.thinkbroadband.com/download
  3. click any of the links
  4. select "save as" instead of "open"
  5. wait for the download panel to show (it might not, bug 1685736)
  6. close the panel
  7. restart Firefox (either for an update, or just quit it and reopen it)

ER:
the panel does not open up again for the same download

AR:
the panel opens up again

This would get very annoying after a while, and the only workaround appears to be removing the download from your history, by using the context menu or the download manager. A lot of users won't be able to figure this out.

We shouldn't show the panel for downloads that aren't from the current session.

Assignee: nobody → sstreich
Severity: -- → S3
Status: NEW → ASSIGNED
Priority: -- → P2
Whiteboard: [domsecurity-active]

I can confirm this on macOS.

Assignee: sstreich → julianwels
Duplicate of this bug: 1697837

This is disabled outside of Nightly so updating tracking flags for that...

Duplicate of this bug: 1685151
Attachment #9219056 - Attachment is obsolete: true
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/198b3a144a86
Older blocked mixed-content downloads get removed from download-list on restart. r=Gijs
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.

Flags: qe-verify+

Reproduced this issue on an affected Nightly build from 2021-01-08 on Ubuntu 20.04, following the STR from comment 0.

Verified as fixed on Firefox 91.0.2 (20210823123856) across the following platforms: Ubuntu 20.04, Win 10 x64 and macOS 10.15. The download panel does not open up again after a restart or an update.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.