1686317 - It's no longer possible to scroll the gloda search results

Status: RESOLVED FIXED

(Thunderbird :: Search, defect)

Description

[Alex ARNAUD]

Hello,

Steps to reproduce:

1. Open Thunderbird
2. Press control + k to go on the search input field
3. Type "a" to ensure you'll have a lot of result
4. Press enter, you'll go on a newly opened search results tab
5. Try to scroll down with the mouse

Result:
There is no scroll bar at all and it's not possible to scroll the result.

Expected result:
A scroll bar should be present and It should be possible to scroll.

Thanks in advance.

Comment 1

[Wayne Mery (:wsmwk)]

Another nightly regression?

Comment 2

[Calum Mackay]

Confirmed, MacOS Daily 20210112

Although for me, "a" isn't long enough to trigger a search; I used "test".

You can, of course, use "show results as list", to get a normal view, and scroll that.

I'll try some older builds…

Comment 3

[Calum Mackay]

The oldest build I have on this system is 20210107, and that shows the same behaviour.

Comment 4

[Calum Mackay]

Same behaviour with 20210101; I'm not sure when this last scrolled, as I never use it: I always go from that view directly to "show results as list",

Comment 5

[Magnus Melin [:mkmelin]]

Pretty sure this was regressed by bug 1572062.

Comment 6

[Magnus Melin [:mkmelin]]

Attachment: bug1686317_glodascroll.patch

I don't really know why it worked without this before.

Comment 7

[Richard Marti (:Paenglab)]

Comment on attachment 9198896 [details] [diff] [review]
bug1686317_glodascroll.patch

Review of attachment 9198896 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

::: mail/base/content/glodaFacetView.css
@@ +3,5 @@
>   * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
>  
>  @import url("chrome://messenger/skin/messenger.css");
>  
> +html, body {

Why this change? We normally do one selector per line.

Comment 8

[Magnus Melin [:mkmelin]]

I'll put them one separate rows. The change is that I split up the height+overflow to be on the body only and not both.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1ffbc71c32ab
make sure gloda search results have scrollable body when needed. r=Paenglab