Closed Bug 1686428 Opened 4 years ago Closed 4 years ago

Non-functional keyboard shortcuts in Address Book: Change Linux shortcut for Advanced Address Book Search on Linux from Shift+F to Ctrl+Shift+F.

Categories

(Thunderbird :: Address Book, defect)

All
Linux
defect

Tracking

(thunderbird_esr78 wontfix)

RESOLVED FIXED
88 Branch
Tracking Status
thunderbird_esr78 --- wontfix

People

(Reporter: valentin, Assigned: thomas8)

References

Details

(Keywords: access, ux-consistency)

Attachments

(2 files)

Open the Address Book (e.g. using <ctrl><shift>B).

The Edit menu suggests that to “Search Addresses…” you need to type Shift+F.
This is a no-op. (Besides, actually activating that menu item opens up the Advanced Search rather than bringing the focus to the simple search field on the upper right.)

The correct (undocumented) shortcut to focus on the search bar is actually <ctrl>K, as in the main window.
If you do just that, then press <ctrl>N to create a new contact: this doesn’t work.

Now hit Tab twice to move to the abResultsTree table (i.e. your contact list), and select any existing contact.
Hit Tab once more to now bring the focus onto that contact’s email address in the contact card on the lower left side.
Now hit <ctrl>N to create a new contact: again, this doesn’t work.

This was reproduced both in Nightly and 78.

(In reply to Valentin Villenave from comment #0)

Hi Valentin, let's look into your issues.

Open the Address Book (e.g. using <ctrl><shift>B).
The Edit menu suggests that to “Search Addresses…” you need to type Shift+F.

I'm looking at Thunderbird 78.6.1 (64-bit), English version, on Win10, and the shortcut for "Search Addresses..." is listed as "Ctrl+Shift+F" (not just Shift+F as you claim). Ctrl+Shift+F works to trigger "Advanced Address Book Search".

  • Are you sure it says Shift+F and not Ctrl+Shift+F?
  • Are you using assistive technology like screen readers?
  • Can you attach a screenshot here?

This is a no-op. (Besides, actually activating that menu item opens up the Advanced Search rather than bringing the focus to the simple search field on the upper right.)
The correct (undocumented) shortcut to focus on the search bar is actually <ctrl>K, as in the main window.

Indeed, Ctrl+K is undocumented shortcut for plain vanilla address book search. We should document that in the placeholder text at least.

If you do just that, then press <ctrl>N to create a new contact: this doesn’t work.

Indeed, that's annoying - on record as Bug 1193160.

Now hit Tab twice to move to the abResultsTree table (i.e. your contact list), and select any existing contact.
Hit Tab once more to now bring the focus onto that contact’s email address in the contact card on the lower left side.
Now hit <ctrl>N to create a new contact: again, this doesn’t work.

Indeed, Ctrl+N does not work with focus in the contact preview pane, either. That's address book for you :-/

Flags: needinfo?(valentin)
Flags: needinfo?(valentin)

Greetings Thomas,
I’m using the GNU/Linux (x86_64) daily build on a Debian buster VM. See attached :-)

That's address book for you :-/

Oh. I sense some deep-rooted frustrations there :-D

As Valentin, I'm on Debian GNU/Linux 10.

On Daily, neither control + shift + f nor shift + f trigger an action for me on the address book.

Thomas, do you know if some shortcuts are localized or specific to a OS?

Thomas, do you know if some shortcuts are localized or specific to a OS?

It's the same behavior with Thunderbird en_us under Debian 10.

Status: UNCONFIRMED → NEW
Ever confirmed: true

Magnus, do you know if someone could try on mac to tell us if it's a Linux specific issue?

Flags: needinfo?(mkmelin+mozilla)

This indeed have a linux specific shortcut. https://searchfox.org/comm-central/rev/75aaa96983fe0c594aba966ba1b2f172c927d831/mail/components/addrbook/content/addressbook.xhtml#163-167. I don't know why we do that, and it predates hg import....

Flags: needinfo?(mkmelin+mozilla)
OS: All → Linux

(In reply to Magnus Melin [:mkmelin] from comment #8)

This indeed have a linux specific shortcut. https://searchfox.org/comm-central/rev/75aaa96983fe0c594aba966ba1b2f172c927d831/mail/components/addrbook/content/addressbook.xhtml#163-167. I don't know why we do that, and it predates hg import....

For consistency with mail advance search, I think we should use control + shift + f here.

(In reply to Thomas D. (:thomas8) from comment #2)

If you do just that, then press <ctrl>N to create a new contact: this doesn’t work.

Indeed, that's annoying - on record as Bug 1193160.
Indeed, Ctrl+N does not work with focus in the contact preview pane, either. That's address book for you :-/

Both of these issues should be easy to fix with a document event listener on Bug 1193160.

Depends on: 1193160

(In reply to Alex ARNAUD from comment #9)

(In reply to Magnus Melin [:mkmelin] from comment #8)

This indeed have a linux specific shortcut. https://searchfox.org/comm-central/rev/75aaa96983fe0c594aba966ba1b2f172c927d831/mail/components/addrbook/content/addressbook.xhtml#163-167. I don't know why we do that, and it predates hg import....

For consistency with mail advance search, I think we should use control + shift + f here.

Taking, let's try that!

Assignee: nobody → bugzilla2007
Flags: needinfo?(bugzilla2007)

Alex, can you check if this works on Linux?
Anywhere in main AB window, Ctrl+Shift+F should now trigger Advanced Address Book Search.
Was Shift+F before and that shortcut reported not working here.

Flags: needinfo?(bugzilla2007)
Attachment #9197868 - Flags: review?(alessandro)
Severity: -- → S3
Status: NEW → ASSIGNED
Comment on attachment 9197868 [details] [diff] [review] Ctrl+Shift+F-AB-search-Linux.diff Review of attachment 9197868 [details] [diff] [review]: ----------------------------------------------------------------- Indeed, this works on Linux now, thanks.
Attachment #9197868 - Flags: review?(alessandro) → review+

Hmmm, sorry, forgot to flag this checkin-needed... patch still applies cleanly as of today.

Summary: Non-functional keyboard shortcuts in Address Book → Non-functional keyboard shortcuts in Address Book: Change Linux shortcut for Advanced Address Book Search on Linux from Shift+F to Ctrl+Shift+F.

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/36c683997590
Change shortcut for Advanced Address Book Search on Linux to Ctrl+Shift+F. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: