Open Bug 1193160 Opened 5 years ago Updated 1 year ago
Allow creating new contacts and lists when AB quick search field has focus: Enable [New Contact] and [New List] commands which are disabled
+++ This bug was initially created as a clone of Bug #1143812 +++ Per bug 1143812, we want [New Contact] and [New List] commands to be always enabled in AB regardless of current focus, defaulting to "Personal AB". They should never be disabled. In bug 1143812, as a workaround we temporarily disabled focusing the search box to keep these enabled when AB window opens, as it was not clear how to reliably enable them. So that workaround should be reverted here. http://mxr.mozilla.org/comm-central/source/mail/components/addrbook/content/addressbook.js#214 > 214 // Focus the searchbox as we think the user will want to do that > 215 // with the highest probability. > 216 // Bug 1143812: This is disabled for now to keep the New Contact command enabled. > 217 // QuickSearchFocus(); (In reply to :aceman from bug 1143812 comment #51) > (In reply to Thomas D. from bug 1143812 comment #50) > > Would it help to remove the following lines which seem superfluous: > > http://mxr.mozilla.org/comm-central/source/mail/components/addrbook/content/ > > abCommon.js#498 > > 498 goUpdateCommand('cmd_newlist'); > > 499 goUpdateCommand('cmd_newCard'); > > > > goUpdateCommand does nothing but en/disable commands; if we never disable, > > this shouldn't be needed. > > Even if we remove the explicit updates, something implicit may still update > the commands. So I would still consider it risky.
Aceman, are you taking this?
Assignee: nobody → acelists
You need to log in before you can comment on or make changes to this bug.