1687543 - Improve some strings when importing CSV text files to address book to clarify import data preview

Status: RESOLVED FIXED

(Thunderbird :: Address Book, enhancement)

Description

[DigNap15]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:84.0) Gecko/20100101 Firefox/84.0

Steps to reproduce:

When I try to import a csv file to my address book, it only allows me to import one record at at time - eg NEXT / PRVIOUS
There should be an all option
Otherwise it takes for ever to import say 20 new addresses!

Actual results:

It also show an error after if imports the single record

Comment 1

[Thomas D. (:thomas8)]

Hi DigNap15, thank you and sorry for the poor user experience of this dialog... You've digged out an age-old sore spot from the internals of Thunderbird... This dialog has been on a nap for the last two decades and it's about time to do something about it. We've started the process of getting the AB in general ready for improvements... between hundreds of other pressing issues!

You've been mislead by the poor wording: Imported data for record: 1 is only about previewing the records of your import (to see how they will be imported), so it has nothing to do with the number of records being imported, which will always be all records. Unfortunately, as you correctly observed, the import is also broken.
I'll morph this to improve the label and the title of the dialog, and then we need to ensure having a bug for the import error.

Comment 2

[Thomas D. (:thomas8)]

I suggest the following string changes:

Dialog title: Import Address Book --> Import Address Book from Text File
First label: Import data for record: 1 --> Preview of import data for record: 1
OK button: --> Import

Comment 3

[Thomas D. (:thomas8)]

(In reply to DigNap15 from comment #0)

Actual results:
It also show an error after if imports the single record

The import error is on record as bug 1671562.

Comment 4

[Liscare]

Attachment: Bug 1687543 - Improve strings when importing text files to Address Book in import data preview. r=thomasD, aleca

Comment 5

[Thomas D. (:thomas8)]

Bug 1719467 has touched fieldMapImport.xhtml

Comment 6

[Liscare]

Attachment: Bug 1687543 - Improve strings when importing text files to Address Book in import data preview. r=thomasD

Disambiguate some strings which caused user confusion in the Import Address Book from Text File dialog, and port them to Fluent.

Comment 7

[Thomas D. (:thomas8)]

This patch has strings, kindly land asap.

I've commandeered this revision via the Mozilla Phabricator web UI, and it looks 100% correct there wrt commit message and author.
In spite of that, Alex noted there seems to be something wrong with the patch.
When landing, pls double-check if the patch has a commit message and is authored by User Lilian Braud <[e-mail]>.
Thank you.

# HG changeset patch
# User Lilian Braud <[e-mail]>
# Parent  87471ad191de65fd867565b8c44f6359dbca83da
Bug 1687543 - Improve strings when importing text files to Address Book in import data preview. r=thomasD, aleca

Summary details:
Disambiguate some strings which caused user confusion in the Import Address Book from Text File dialog, and port them to Fluent.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/98cc2530f612
Improve strings when importing text files to Address Book in import data preview. r=thomasD,aleca

Comment 9

[Thomas D. (:thomas8)]

Unfortunately, the new Fluent file which the patch was adding got lost upon check-in, so the new strings are missing (mail/locales/en-US/messenger/addressbook/fieldMapImport.ftl).

https://phabricator.services.mozilla.com/D110768?vs=on&id=457193#toc (adds a fluent file)
https://hg.mozilla.org/comm-central/rev/98cc2530f612 (does not add a fluent file)

Comment 10

[Geoff Lankow (:darktrojan)]

Something made a right mess of that patch. I'm going to blame Mercurial (definitely wasn't me…).

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/71909b9efee7
follow-up - Land missed file. r=thomasD,aleca

Comment 12

[Thomas D. (:thomas8)]

Attachment: Screenshot 1: Missing strings on 91.0b2 (64-bit)

This is incomplete on 91.0b2, resulting in a broken import dialog - we need to uplift the missing parts of this patch (comment 11).

A new Fluent string file from the patch got lost when landing this shortly before 91 went to beta (comment 9).
The string file was then added on Daily 92 (comment 11). So it's still missing on the Beta 91 channel which will become the release (see screenshot of 91.0b2) - easy to fix by uplifting the missing bits.

Comment 13

[Thomas D. (:thomas8)]

Comment on attachment 9213465 [details]
Bug 1687543 - Improve strings when importing text files to Address Book in import data preview. r=thomasD, aleca

[Approval Request Comment]
Regression caused by (bug #): patch was landed incompletely with a new Fluent file missing (see comment 12)
User impact if declined: Import Address Book from Text File dialog without title and other strings missing (see screenshot attachment 9232101 [details])
Testing completed (on c-c, etc.): yes
Risk to taking this patch (and alternatives if risky): Low. Involves strings. We must be able to fix broken strings even after string freeze.

Comment 14

[Wayne Mery (:wsmwk)]

Comment on attachment 9213465 [details]
Bug 1687543 - Improve strings when importing text files to Address Book in import data preview. r=thomasD, aleca

[Triage Comment]
Approved for beta

You'll want to let localizers know of any "late string" issues.

Comment 15

[Thomas D. (:thomas8)]

(In reply to Wayne Mery (:wsmwk) from comment #14)

You'll want to let localizers know of any "late string" issues.

@Wayne: See PM on Matrix at 13:08 CEST today.

Comment 16

[Rob Lemley [:rjl]]

Thunderbird 91.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/aa6f2864a1e1

Comment 17

[Worcester12345]

Just did an address book import today. Still a cluster. It should allow you to check and uncheck fields you want, and make them easier to shift. It is always a weird way of using up arrows to move a field, but it is always opposite of what one wants. It is like backing up a trailer without a rear view mirror.

Comment 18

[Thomas D. (:thomas8)]

Attachment: Screenshot: Import dialog (before and after)

Thank you very much Lilian for improving this dialog!

35 localizations around the world have translated our new strings, have a look:
https://searchfox.org/l10n/search?q=import-ab-csv-preview-record-number&path=

That's not bad, I think. Compare:
53 localizations translated address-input-type-aria-label from messengercompose.ftl:
https://searchfox.org/l10n/search?path=&q=address-input-type-aria-label

The maximum number of theoretically available localizations is probably 70.
https://searchfox.org/l10n/search?q=&path=messengercompose.ftl&case=false&regexp=false

Strangely, only 68 flavors of our new file here (meaning two are missing):
https://searchfox.org/l10n/search?q=&path=fieldMapImport.ftl&case=false&regexp=false

Comment 19

[Thomas D. (:thomas8)]

(In reply to Worcester12345 from comment #17)

Just did an address book import today. Still a cluster. It should allow you to check and uncheck fields you want, and make them easier to shift. It is always a weird way of using up arrows to move a field, but it is always opposite of what one wants. It is like backing up a trailer without a rear view mirror.

LOL... that's right Worcester12345, and tracked in bug 95087!