1719467 - Some dialogs have an invisible background

Status: VERIFIED FIXED

(Thunderbird :: Theme, defect)

Description

[Alfred Peters [:infofrommozilla]]

Attachment: NewTagDialog.png

+++ This bug was initially created as a clone of Bug #1719179 +++

If I invoke: menu -> View -> Messages -> Customize...
the dialog background is invisible.

Another case is: menu -> Message -> Tag -> New Tag...

This case seams theme dependent:

• In system theme the background is invisible
• In dark theme there is black text on black background
• But Light theme seams to be OK

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1719467-exchange-dialogs.css.patch

In bug 1717079 I missed this dialogs.

Additionally I made them themeable too. I also copied the newTagDialog.xhtml into preferences to get a themeableDialog.css etc. free version that shows the buttons correct.

Comment 2

[Alfred Peters [:infofrommozilla]]

See also: Bug 1719431

Comment 3

[Richard Marti (:Paenglab)]

Attachment: 1719467-exchange-dialogs.css.patch

Same patch but with pre-processing the tag dialog to have the content only in one file.

Comment 4

[Alessandro Castellani [:aleca]]

Comment on attachment 9230136 [details] [diff] [review]
1719467-exchange-dialogs.css.patch

Review of attachment 9230136 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, I think this is the better approach so we don't have duplications.
Please, update the commit message with:

"Use an inc file for the Tag dialog in the preferences and mail UI, and make more dialogs themeable"

::: mail/base/content/tagDialog.inc.xhtml
@@ +25,5 @@
> +    <html:input type="color" id="tagColorPicker"/>
> +  </box>
> +  <separator/>
> +</dialog>
> +</window>

I think the closing markup of the dialog and window shouldn't be in the inc file.

Comment 5

[Alessandro Castellani [:aleca]]

Let's kick a try run to be sure the dupes are properly defined and we're not busting anything.

Comment 6

[Richard Marti (:Paenglab)]

Attachment: 1719467-exchange-dialogs.css.patch

Addressed the review comment.

Try: https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=280f0d9590ca093225d57f0824cedcdc6577404a

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e68769bc4906
Exchange the removed dialogs.css with the messenger.css and make more dialogs themeable. r=aleca