Closed Bug 1688051 Opened 4 years ago Closed 4 years ago

Password csv import summary has wrong count of number of new logins added

Categories

(Toolkit :: Password Manager, defect, P2)

Product:
Toolkit
Component:
Password Manager
Version:
Firefox 86
Type:
defect

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: petcuandrei, Unassigned)

References

(Blocks 1 open bug)

Details

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:86.0) Gecko/20100101 Firefox/86.0

Steps to reproduce:

Import passwords from a CSV file

Actual results:

The import dialog shows wrong number of imported logins

Expected results:

It should have shown the correct number.

Blocks: 1303176

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Component: Untriaged → Password Manager
Product: Firefox → Toolkit

good bot
lazy human

Reminder to myself to get a test case on here to prove/disprove that we result from maybeImportLogins needs filtering to get an accurate count of how many logins got imported.

Flags: needinfo?(sfoster)
Summary: Password csv import summary has wrong "New logins added:" → Password csv import summary has wrong count of number of new logins added
Severity: -- → S3
Flags: needinfo?(sfoster)
Priority: -- → P2
Flags: needinfo?(sfoster)

The latest patch has added good test coverage for the result objects we return back from maybeImportLogins.

Flags: needinfo?(sfoster)

Soooo.... can't reproduce?

Blocks: 1688213

Any update on this Sam?

Flags: needinfo?(sfoster)

Sorry I should have closed this the other day. There's nothing we need to do here now.

Status: NEW → RESOLVED
Closed: 4 years ago
Flags: needinfo?(sfoster)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.