1688800 - Carve out more edge cases for javascriptLoad restrictions, and let Telemetry ride the trains

Status: RESOLVED FIXED

(Firefox :: Security, enhancement)

Description

[Tom Ritter [:tjr]]

See discussion in https://github.com/xiaoxiaoflood/firefox-scripts/issues/64

Specifically:

Presently my dataset is restricted to Nightly, so it may be coming primarily from bootstrapLoader.xpi. I'm going to propose checking for xpinstall.signatures.required = false and if so, disable our checks. Hopefully that quiets down the activity. It's preferable to get the data down to near-zero, that means that we understood what the problem was and there's less chance of breaking something unknown!

The other possibility is workers; but given the example provided actually uses the chrome:// scheme (and we allow those) I'm feeling less sure of this. Still; I don't think it would be hard to introduce a static variable to check general.config.filename off-main-thread. (TBH I'm not sure why I didn't do that in the beginning.)

Comment 1

[Tom Ritter [:tjr]]

Attachment: Bug 1688800: Carve out more edge cases for javascriptLoad restrictions, and let Telemetry ride the trains r?ckerschb

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ade9dd19ad1
Carve out more edge cases for javascriptLoad restrictions, and let Telemetry ride the trains r=ckerschb

Comment 3

[Cristian Brindusan [:cbrindusan]]

Backed out changeset 2ade9dd19ad1 (bug 1688800) for build bustages at nsContentSecurityUtils.cpp.
https://hg.mozilla.org/integration/autoland/rev/f808cc5ebe004bb4f316cf068b8b61d54b18b1e3

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&revision=2ade9dd19ad1d18ab8b1ade6090d5c8c8308213d&selectedTaskRun=B03AzYDpS76NHGCXW5Ga9g.0

Failure log:
https://treeherder.mozilla.org/logviewer?job_id=328122269&repo=autoland&lineNumber=44177

Comment 4

[Tom Ritter [:tjr]]

Oops. Sorry.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c77e7ee7683a
Carve out more edge cases for javascriptLoad restrictions, and let Telemetry ride the trains r=ckerschb

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/c77e7ee7683a