1689079 - account provisioning should allow the provider to send back the email and name to be used

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, enhancement)

Description

[Magnus Melin [:mkmelin]]

Attachment: bugXXX_provider.patch

During account provisioning the chosen email and display name may change from what the user had originally entered. We should allow to set the chosen values to use for the setup.

Looks like the final step of getting the account configured (see TracingListener) seems not to be working atm, likely broken by tb-fission.

Attaching wip patch (that doesn't work on trunk)

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: bug1689079_provider.patch

Slight update.

I tested this on 78 and there it works. On trunk, when one gets the account setup, and would press "finish" in the provider page, the link opens in a tb tab AND in the browser. But the listening for the response doesn't work.

Comment 2

[Magnus Melin [:mkmelin]]

Seems bug 1658781 was not 100% fixed - if i set up the same account many times, I seem to get trouble in the account settings, but I don't know why.

For 78 when I say it it works, it works - but if it's a blank profile, the account hub doesn't at least always go away and one have to restart to get the folder pane to start showing.

Comment 3

[Alessandro Castellani [:aleca]]

Seems bug 1658781 was not 100% fixed - if i set up the same account many times, I seem to get trouble in the account settings, but I don't know why.

I'll take a look at it and create a follow up bug.

Comment 4

[Magnus Melin [:mkmelin]]

Attachment: bug1689079_provider.patch

With bug 1689290 fixed, this now works on trunk.

Comment 5

[Alessandro Castellani [:aleca]]

Comment on attachment 9199753 [details] [diff] [review]
bug1689079_provider.patch

Review of attachment 9199753 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good and works as expected.

I opened bug 1689724 for the UI not updating after a successful config.

Comment 6

[Alessandro Castellani [:aleca]]

bug 1689724 seems to happen only when creating a new email address.
When I configure an existing account it triggers the UI changes.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/340c94242df2
allow account provisioning to use provider email and displayname, and fix some bugs. r=aleca

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0880364fd414
followup - fix lanugage selection to make tests pass. rs=me

Comment 9

[Magnus Melin [:mkmelin]]

Comment on attachment 9199753 [details] [diff] [review]
bug1689079_provider.patch

[Approval Request Comment]
Wanted for beta to advance partnership integration work.
Fixes real problem as well, in that the provider success dialog didn't close anymore on trunk. Likely due to tb-fission.
Both changeset should be uplifted.

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9199753 [details] [diff] [review]
bug1689079_provider.patch

[Triage Comment]
Approved for beta

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 86.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/e7970cf700bc
https://hg.mozilla.org/releases/comm-beta/rev/d4e3e486b0c5

Comment 12

[Magnus Melin [:mkmelin]]

Comment on attachment 9199753 [details] [diff] [review]
bug1689079_provider.patch

[Approval Request Comment]
Forgot to ask for 78 approval for this earlier...

Comment 13

[Wayne Mery (:wsmwk)]

Comment on attachment 9199753 [details] [diff] [review]
bug1689079_provider.patch

[Triage Comment]
Approved for esr78

Comment 14

[Rob Lemley [:rjl]]

Thunderbird 78.8.1:
https://hg.mozilla.org/releases/comm-esr78/rev/71bd4e678b52
Thunderbird 78.8.1:
https://hg.mozilla.org/releases/comm-esr78/rev/6cb24f23251a