Closed Bug 1689079 Opened 4 years ago Closed 4 years ago

account provisioning should allow the provider to send back the email and name to be used

Categories

(Thunderbird :: Account Manager, enhancement)

enhancement

Tracking

(thunderbird_esr78+ fixed, thunderbird86+ fixed)

RESOLVED FIXED
87 Branch
Tracking Status
thunderbird_esr78 + fixed
thunderbird86 + fixed

People

(Reporter: mkmelin, Assigned: mkmelin)

References

Details

Attachments

(1 file, 2 obsolete files)

Attached patch bugXXX_provider.patch (obsolete) — Splinter Review

During account provisioning the chosen email and display name may change from what the user had originally entered. We should allow to set the chosen values to use for the setup.

Looks like the final step of getting the account configured (see TracingListener) seems not to be working atm, likely broken by tb-fission.

Attaching wip patch (that doesn't work on trunk)

Attached patch bug1689079_provider.patch (obsolete) — Splinter Review

Slight update.

I tested this on 78 and there it works. On trunk, when one gets the account setup, and would press "finish" in the provider page, the link opens in a tb tab AND in the browser. But the listening for the response doesn't work.

Assignee: nobody → mkmelin+mozilla
Attachment #9199496 - Attachment is obsolete: true

Seems bug 1658781 was not 100% fixed - if i set up the same account many times, I seem to get trouble in the account settings, but I don't know why.

For 78 when I say it it works, it works - but if it's a blank profile, the account hub doesn't at least always go away and one have to restart to get the folder pane to start showing.

Seems bug 1658781 was not 100% fixed - if i set up the same account many times, I seem to get trouble in the account settings, but I don't know why.

I'll take a look at it and create a follow up bug.

With bug 1689290 fixed, this now works on trunk.

Attachment #9199596 - Attachment is obsolete: true
Attachment #9199753 - Flags: review?(alessandro)
Status: NEW → ASSIGNED
Target Milestone: --- → 87 Branch
Comment on attachment 9199753 [details] [diff] [review] bug1689079_provider.patch Review of attachment 9199753 [details] [diff] [review]: ----------------------------------------------------------------- This looks good and works as expected. I opened bug 1689724 for the UI not updating after a successful config.
Attachment #9199753 - Flags: review?(alessandro) → review+

bug 1689724 seems to happen only when creating a new email address.
When I configure an existing account it triggers the UI changes.

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/340c94242df2
allow account provisioning to use provider email and displayname, and fix some bugs. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Pushed by mkmelin@iki.fi: https://hg.mozilla.org/comm-central/rev/0880364fd414 followup - fix lanugage selection to make tests pass. rs=me

Comment on attachment 9199753 [details] [diff] [review]
bug1689079_provider.patch

[Approval Request Comment]
Wanted for beta to advance partnership integration work.
Fixes real problem as well, in that the provider success dialog didn't close anymore on trunk. Likely due to tb-fission.
Both changeset should be uplifted.

Attachment #9199753 - Flags: approval-comm-beta?

Comment on attachment 9199753 [details] [diff] [review]
bug1689079_provider.patch

[Triage Comment]
Approved for beta

Attachment #9199753 - Flags: approval-comm-beta? → approval-comm-beta+
See Also: → tb-fission

Comment on attachment 9199753 [details] [diff] [review]
bug1689079_provider.patch

[Approval Request Comment]
Forgot to ask for 78 approval for this earlier...

Attachment #9199753 - Flags: approval-comm-esr78?

Comment on attachment 9199753 [details] [diff] [review]
bug1689079_provider.patch

[Triage Comment]
Approved for esr78

Attachment #9199753 - Flags: approval-comm-esr78? → approval-comm-esr78+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: