1689251 - Options New Tabs always says Firefox Home

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[Sylvain]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0

Steps to reproduce:

Updated to FF85, went through options looking to disable some of those new search-results-in-address-bar (TAB to search or something) and discovered Firefox said my NEW TABS would be Firefox Home (default). I thought this was strange as my new tabs are blank and always have been. I changed it back to Blank Page, closed and re-opened Options, and there it again said Firefox Home, even though it is not true.

Actual results:

Options -> New Tabs does not display correct value, always shows Firefox Home.

Expected results:

Options -> New Tabs should display Blank Page when this is what is enabled.

Comment 1

[Andrei Purice]

Hey Sylvain,
I tried reproducing this issue on the latest versions of Firefox Nightly 87.0a1 (2021-02-01), beta 86.0b4 and release 85.0 but after switching to blank page on options and restarting the browsers there are no other changes than the selected blank page for any new tab.

Can you test the issue while in Safe Mode? You can find helpful info here : https://support.mozilla.org/en-US/kb/troubleshoot-firefox-issues-using-safe-mode .
Also a fresh new profile could help. You can find more about creating a new profile here : https://support.mozilla.org/en-US/kb/troubleshoot-and-diagnose-firefox-problems#w_6-create-a-new-firefox-profile .
If possible, you can test this issue on the nightly build as well. Download the build from : https://www.mozilla.org/en-US/firefox/nightly/all/ .

Comment 2

[Sylvain]

Attachment: Captura-2021-02-01-21-29-50.mp4

I guess my description is not the best, here's a video. the NEW TABS choice does not remember Blank, it just displays Firefox Home all the time...

Comment 3

[Sylvain]

PS: Video above is on a virgin profile...

Comment 4

[Marc Auslander]

For what it's worth I had no trouble reproducing on 85.0 clean profile windows 10 20H2.

Comment 5

[WaltS48 [:walts48]]

I can reproduce using Firefox 85.0 on Fedora 33 Workstation.

Comment 6

[Alice0775 White]

STR:

1. open about:preferences
2. Click "Home" in left pane
3. Select "Blank page" for "New tab"
4. Reload (F5)
5. Click "Home" in left pane

Actual results:
The selection becomes "Firefox Home(Default)".
However, Ctrl+T creates "Blank page" as expected.
So, it seems that the option page seems to fail initializing.

Expected results:
The selection should persist as "Blank page"

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=0214170e4e168311884d939ec961d94bed65ee38&tochange=87879291472821637d2cf1d72b5d2e18701d8d3a

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Thanks for the regression window, Alice0775 White!

Hey ewright, any idea what's going on here?

Comment 8

[Erica Wright [:ewright]]

Attachment: Bug 1689251 - About:preferences new tab input syncs value from pref.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c63a7ba116f7
About:preferences new tab input syncs value from pref. r=preferences-reviewers,mixedpuppy

Comment 10

[:Gijs (he/him)]

Erica, how safe do you think this patch is for uplift to beta, and if that'd be OK, would you mind filling out an uplift request? It'd go straight into rc.

Comment 12

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/c63a7ba116f7

Comment 13

[Erica Wright [:ewright]]

@gijs, sorry for missing the beta build, I was on PTO. Not much longer till it is onto release at this point now, though.