1595858 - support extension selection for homepage and newtab

Status: RESOLVED FIXED

(WebExtensions :: Frontend, enhancement, P2)

Description

[Shane Caraveo (:mixedpuppy)]

UX details are in bug 1548700. Basically we add extensions to the dropdowns for these settings.

Comment 1

[Mark Striemer [:mstriemer]]

Bug 1548700 comment 5 has a description of how to start on this UX wise.

Comment 2

[Mark Striemer [:mstriemer]]

I will attach my WIP patch.

Comment 3

[Mark Striemer [:mstriemer]]

Here's my WIP patch https://gist.github.com/mstriemer/442912a30cca4c2d27c25d8340c15eaf.

The test unfortunately isn't passing, I think because the dropdown isn't being updated when the add-on is installed. I dug into it a little and I think it's because once the select has been changed installing an add-on will no longer make it immediately become the default. I don't recall if this was expected or not, but I think we had discussed it when I was first working on this.

Comment 4

[Jorge Villalobos [:jorgev] (he/him)]

Bug 1461348 is effectively the same as this one, right?

Comment 6

[Erica Wright [:ewright]]

Attachment: Bug 1595858 - Allow users to select or deselect addons for homepage and newtab without disabling the addons.

Bug 1595858 - Allow users to select or deselect addons for hompage and newtab without disabling the addons.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d86e4d6c2be4
Allow users to select or deselect addons for homepage and newtab without disabling the addons. r=preferences-reviewers,Gijs,mixedpuppy

Comment 8

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d70bf7b7cef9
Backed out changeset d86e4d6c2be4 for browser_ext_chrome_settings_overrides_home.js failures CLOSED TREE

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

Backed out changeset d86e4d6c2be4 (bug 1595858) for browser_ext_chrome_settings_overrides_home.js failures.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=OrMBc0AQQPumgcb4oPSvWg.0&fromchange=d86e4d6c2be461b9401a96192f8f3daebae036bf&searchStr=mochitest-browser-chrome&tochange=23b8e2facfb9860427b51b8fbad686def2d2ac29

Backout link: https://hg.mozilla.org/integration/autoland/rev/d70bf7b7cef939d678ab162b5ae2725cee322f78

Failure log: https://treeherder.mozilla.org/logviewer?job_id=321658302&repo=autoland&lineNumber=37464

...
[task 2020-11-13T03:50:53.675Z] 03:50:53     INFO - TEST-OK | browser/components/extensions/test/browser/browser_ext_windows_update.js | took 8012ms
[task 2020-11-13T03:50:53.685Z] 03:50:53     INFO - GECKO(8048) | [Child 928: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0000023DA666BC00 == 2 [pid = 928] [id = 323]
[task 2020-11-13T03:50:53.685Z] 03:50:53     INFO - GECKO(8048) | [Child 928: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 8 (0000023DA3EFA3C0) [pid = 928] [serial = 812] [outer = 0000000000000000]
[task 2020-11-13T03:50:53.685Z] 03:50:53     INFO - GECKO(8048) | [Child 928: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 9 (0000023DA6672C00) [pid = 928] [serial = 813] [outer = 0000023DA3EFA3C0]
[task 2020-11-13T03:50:53.704Z] 03:50:53     INFO - checking window state
[task 2020-11-13T03:50:53.755Z] 03:50:53     INFO - GECKO(8048) | [Parent 7788: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 151 (0000024E22A99000) [pid = 7788] [serial = 1323] [outer = 0000024E114783C0]
...
[task 2020-11-13T03:51:12.811Z] 03:51:12     INFO - GECKO(8048) | Completed ShutdownLeaks collections in process 7788
[task 2020-11-13T03:51:12.811Z] 03:51:12     INFO - TEST-START | Shutdown
[task 2020-11-13T03:51:12.813Z] 03:51:12     INFO - Browser Chrome Test Summary
[task 2020-11-13T03:51:12.813Z] 03:51:12     INFO - Passed:  8384
[task 2020-11-13T03:51:12.813Z] 03:51:12     INFO - Failed:  0
[task 2020-11-13T03:51:12.813Z] 03:51:12     INFO - Todo:    11
[task 2020-11-13T03:51:12.813Z] 03:51:12     INFO - Mode:    e10s
[task 2020-11-13T03:51:12.813Z] 03:51:12     INFO - *** End BrowserChrome Test Results ***
[task 2020-11-13T03:51:12.893Z] 03:51:12     INFO - GECKO(8048) | [Child 2200, Main Thread] WARNING: '!CanSend() || !mManager || !mManager->CanSend()', file /builds/worker/checkouts/gecko/dom/ipc/jsactor/JSWindowActorChild.cpp:40
...
[task 2020-11-13T03:51:17.018Z] 03:51:17     INFO - GECKO(8048) | [Parent 7788, Main Thread] WARNING: NS_ENSURE_TRUE(Preferences::InitStaticMembers()) failed: file /builds/worker/checkouts/gecko/modules/libpref/Preferences.cpp:4287
[task 2020-11-13T03:51:17.119Z] 03:51:17     INFO - TEST-INFO | Main app process: exit 0
[task 2020-11-13T03:51:17.119Z] 03:51:17     INFO - TEST-INFO | Confirming we saw 2560 DOCSHELL created and 2556 destroyed log strings.
[task 2020-11-13T03:51:17.120Z] 03:51:17     INFO - TEST-INFO | Confirming we saw 6852 DOMWINDOW created and 6834 destroyed log strings.
[task 2020-11-13T03:51:17.120Z] 03:51:17    ERROR - TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_chrome_settings_overrides_home.js | leaked 1 window(s) until shutdown [url = about:blank]
[task 2020-11-13T03:51:17.121Z] 03:51:17    ERROR - TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_chrome_settings_overrides_home.js | leaked 1 window(s) until shutdown [url = chrome://browser/content/browser.xhtml]
[task 2020-11-13T03:51:17.121Z] 03:51:17     INFO - TEST-INFO | browser/components/extensions/test/browser/browser_ext_chrome_settings_overrides_home.js | windows(s) leaked: [pid = 7788] [serial = 159], [pid = 7788] [serial = 158]
...

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/26f7d3a8b1b6
Allow users to select or deselect addons for homepage and newtab without disabling the addons. r=preferences-reviewers,Gijs,mixedpuppy

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/42e7e98c701d
sBacked out changeset 26f7d3a8b1b6 for overrides related mochitest failures CLOSED TREE

Comment 12

[Bogdan Tara[:bogdan_tara | bogdant]]

Backed out changeset 26f7d3a8b1b6 (bug 1595858) for overrides related mochitest failures.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&fromchange=26f7d3a8b1b670faae60b858ed3bc40e4fbf59a3&searchStr=mochitest&selectedTaskRun=G1KBQ9EUSh-d7BFhjRHDQg.0&tochange=42e7e98c701d3e8c8c66a5acca0f0aeeb5076661

Backout link: https://hg.mozilla.org/integration/autoland/rev/42e7e98c701d3e8c8c66a5acca0f0aeeb5076661

Failures log: https://treeherder.mozilla.org/logviewer?job_id=322104778&repo=autoland&lineNumber=38058

...
[task 2020-11-17T22:52:01.286Z] 22:52:01     INFO - GECKO(5980) | [Parent 8044, Main Thread] WARNING: NS_ENSURE_TRUE(Preferences::InitStaticMembers()) failed: file /builds/worker/checkouts/gecko/modules/libpref/Preferences.cpp:4287
[task 2020-11-17T22:52:01.352Z] 22:52:01     INFO - TEST-INFO | Main app process: exit 0
[task 2020-11-17T22:52:01.352Z] 22:52:01     INFO - TEST-INFO | Confirming we saw 2555 DOCSHELL created and 2549 destroyed log strings.
[task 2020-11-17T22:52:01.352Z] 22:52:01     INFO - TEST-INFO | Confirming we saw 6839 DOMWINDOW created and 6822 destroyed log strings.
[task 2020-11-17T22:52:01.357Z] 22:52:01    ERROR - TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_chrome_settings_overrides_home.js | leaked 1 window(s) until shutdown [url = about:blank]
[task 2020-11-17T22:52:01.357Z] 22:52:01    ERROR - TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_chrome_settings_overrides_home.js | leaked 1 window(s) until shutdown [url = chrome://browser/content/browser.xhtml]
[task 2020-11-17T22:52:01.358Z] 22:52:01     INFO - TEST-INFO | browser/components/extensions/test/browser/browser_ext_chrome_settings_overrides_home.js | windows(s) leaked: [pid = 8044] [serial = 159], [pid = 8044] [serial = 158]
...

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/878792914728
Allow users to select or deselect addons for homepage and newtab without disabling the addons. r=preferences-reviewers,Gijs,mixedpuppy,ahal

Comment 14

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/878792914728