1689461 - Address book and calendar printing are broken

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Geoff Lankow (:darktrojan)]

The print engine can't print remote pages such as data: URLs, which calendar uses. I'm also going to convert the address book printing to use a data: URL instead of the insane way it currently works.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1689461 - Fix address book and calendar printing. r?rnons

The calendar print preview and msgPrintEngine code are not capable of printing remote URLs (ie. data: URLs in this case).

This fixes that and also moves the address book printing code into JS with a blob: URL. The C++ printing code will be removed in a subsequent patch.

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1689461 - Remove the addbook protocol. r?rnons

The addbook protocol was invented for printing address books and adding vCards to the address book.
It's useless for both of those purposes now and this patch removes it.

Depends on D103432

Comment 3

[Geoff Lankow (:darktrojan)]

Comment on attachment 9199971 [details]
Bug 1689461 - Fix address book and calendar printing. r?rnons

[Approval Request Comment]
Regression caused by (bug #): tb-fission
User impact if declined: address book and calendar can't be printed
Testing completed (on c-c, etc.): not yet landed
Risk to taking this patch (and alternatives if risky): none that I can think of, I've tested the other uses of the code I'm changing

It should be possible to uplift this patch without the other. But it does depend on bug 1689042 which isn't mine so I'm not requesting approval for it.

Comment 4

[Magnus Melin [:mkmelin]]

(Clearing checkin-needed - open question on phab)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/abec6012de61
Fix address book and calendar printing. r=rnons
https://hg.mozilla.org/comm-central/rev/81ee7c1eb44a
Remove the addbook protocol. r=rnons

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9199971 [details]
Bug 1689461 - Fix address book and calendar printing. r?rnons

[Triage Comment]
Approved for beta

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 86.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/cbefd6c1f160