1694947 - starting with --addressbook is broken

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect)

Description

[Magnus Melin [:mkmelin]]

Starting with --addressbook doesn't work.
It's due to this line: https://searchfox.org/comm-central/rev/7dcededfeafb2a0c052c7329cc7cfdcbc7f1111c/mail/components/addrbook/content/addressbook.js#112 - we don't have an opener.

Comment 1

[Magnus Melin [:mkmelin]]

Given that this is not a super common use case, and it wouldn't be a problem once we moved the address book into a tab (later), me and Geoff agreed it's likely best just to make sure the line above doesn't throw, and the disable printing if you opened the address book from here.
I think the disabling is around here: https://searchfox.org/comm-central/rev/7dcededfeafb2a0c052c7329cc7cfdcbc7f1111c/mail/components/addrbook/content/abCommon.js#135

Comment 2

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug 1694947 - Handle null opener in addressbook. r=darktrojan

When the --addressbook command option is passed to thunderbird, the address book is launched without an opener.

The opener is needed for setting browserDOMWindow, which is used for printing.

The lack of an opener will no longer be a problem when the address book opens in a tab. So for the time being, printing is disabled or silently fails without an opener.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c49ecc44a835
Handle null opener in addressbook. r=darktrojan