1689705 - Remove <marquee> events

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P3)

Description

[Domenic Denicola]

They are only implemented in Firefox.

Spec change: https://github.com/whatwg/html/pull/6343
Test change: https://github.com/web-platform-tests/wpt/pull/27395

Related Bugzilla bugs:

• https://bugzilla.mozilla.org/show_bug.cgi?id=1392710 (adds use counters)
• https://bugzilla.mozilla.org/show_bug.cgi?id=880425 (seems like this bug would obviate that cleanup)

Comment 1

[Jonathan Kingston [:jkt] he/him]

Attachment: Bug 1689705 - Remove marquee events. r?smaug

Comment 2

[Jonathan Kingston [:jkt] he/him]

The telemetry shows these events are limited in use and probably just abused or just as custom events perhaps?

onbounce - 0.02% https://telemetry.mozilla.org/new-pipeline/dist.html#!cumulative=0&end_date=2021-01-28&include_spill=0&keys=__none__!__none__!__none__&max_channel_version=nightly%252F87&measure=USE_COUNTER2_ONBOUNCE_PAGE&min_channel_version=null&processType=*&product=Firefox&sanitize=1&sort_by_value=0&sort_keys=submissions&start_date=2021-01-25&table=0&trim=1&use_submission_date=0
onstart - 0.10% https://telemetry.mozilla.org/new-pipeline/dist.html#!cumulative=0&end_date=2021-01-28&include_spill=0&keys=__none__!__none__!__none__&max_channel_version=nightly%252F87&measure=USE_COUNTER2_ONSTART_PAGE&min_channel_version=null&processType=*&product=Firefox&sanitize=1&sort_by_value=0&sort_keys=submissions&start_date=2021-01-25&table=0&trim=1&use_submission_date=0
onfinish - 0.11% https://telemetry.mozilla.org/new-pipeline/dist.html#!cumulative=0&end_date=2021-01-28&include_spill=0&keys=__none__!__none__!__none__&max_channel_version=nightly%252F87&measure=USE_COUNTER2_ONFINISH_PAGE&min_channel_version=null&processType=*&product=Firefox&sanitize=1&sort_by_value=0&sort_keys=submissions&start_date=2021-01-25&table=0&trim=1&use_submission_date=0

Anyway as no others implement I think it's been safe to remove for a long time. I submitted a PoC patch, I've not verified that I've got rid of it all.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Those are surprisingly high numbers.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:hsinyi, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1689705 - Remove marquee events. r=smaug

After bug 306344 this is the last remaining incompatibility with
<marquee>. I think we should be able to drop it. Use counters for
"finish" are relatively high (>0.1%), but I'm pretty sure that's because
that event name is shared with web animations. "bounce" is a more
realistic measure, and that's 0.003%, which is more expected.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9455e560433a
Remove marquee events. r=smaug

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2fcfce05b4cf
Remove another mochitest for now-removed marquee events.

Comment 8

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/9455e560433a
https://hg.mozilla.org/mozilla-central/rev/2fcfce05b4cf

Comment 9

[Hamish Willee]

FF126 MDN docs work for this can be tracked in https://github.com/mdn/content/issues/33178. Mostly just a compatibility data update and release note.