1689722 - Quitting Firefox does not remove lock file from profile

Status: RESOLVED WONTFIX

(Toolkit :: Startup and Profile System, defect)

Description

[Asif Youssuff]

Noticed this when trying to run mozregression against an existing Firefox profile - mozregression complained that Firefox was in use because it detected a lock file. I have been manually deleting the lock file, but this is a bug.

Steps to reproduce:

1. Open Firefox.
2. Open profile directory
3. Quit Firefox normally
4. Look in profile directory

What happens:

Firefox leaves a file called "lock" in the directory.

Expected result:

Firefox removes the lock file on successful quit.

15:33.23 INFO: Narrowed integration regression window from [ac6edc02, 8c436ac3] (3 builds) to [ebf55c92, 8c436ac3] (2 builds) (~1 steps left)
15:33.23 INFO: No more integration revisions, bisection finished.
15:33.23 INFO: Last good revision: ebf55c927f7145251191553dfa9eb98bb92359aa
15:33.23 INFO: First bad revision: 8c436ac31df8762c8d1e6434b0a7fa531bb59183
15:33.23 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=ebf55c927f7145251191553dfa9eb98bb92359aa&tochange=8c436ac31df8762c8d1e6434b0a7fa531bb59183

Comment 1

[Dave Townsend [:mossop]]

Does this actually block relaunching the browser?

Comment 2

[Asif Youssuff]

No, I can relaunch the browser, the issue is that I have to manually remove the lock file when using the profile in mozregression, because it expects that the lock file not be present. If this is expected behavior, I suppose that the bug is in mozregression.

Comment 3

[Alex Thayer [:alexical] (she/her)]

My impression is that this is a bug with mozregression. I don't see why we have any obligation to remove the lock file (and doing so can eat time), and if you're debugging a crash via mozregression, you would also run into this.

Comment 4

[Dave Townsend [:mossop]]

I'm inclined to agree, if it isn't blocking the browser from restarting then I think this is something that mozregression is going to need to workaround.