1689934 - Linux 86.0b1: erratic behavior in message pane

Status: VERIFIED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Kalvin Lee]

User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:84.0) Gecko/20100101 Firefox/84.0

Steps to reproduce:

1. Open Thunderbird 86.0b1 (with or without MOZ_ENABLE_WAYLAND; it makes no difference).
2. Open the message pane (if not already in use).
3. Select multiple messages in a particular mailbox (e.g. Ctrl+A to read them all).
4. Attempt to click on a particular message title in the message pane.
5. Attempt to scroll through the aggregate message view with PgUp and PgDn.

Actual results:

WRT step 4: all text in the message pane is selected (highlighted). Message pane continues to display aggregate view of all messages selected and does not focus the message you clicked in step 4.

WRT step 5: nothing happens. (The message pane will respond appropriately to Space and Shift+Space, though.)

Expected results:

WRT step 4: message pane should redraw, un-displaying the aggregate message view; instead, it should display contents of message selected by click in step 4.

WRT step 5: message pane should paginate up once on PgUp and down once on PgDn.

Comment 1

[Wayne Mery (:wsmwk)]

Do you see any similar issues when using Firefox?
Does it happen when starting Thunderbird in safe mode? https://support.mozilla.org/en-US/kb/safe-mode-thunderbird

Comment 2

[WaltS48 [:walts48]]

Mozilla/5.0 (X11; Linux x86_64; rv:86.0) Gecko/20100101 Thunderbird/86.0 on Fedora 33.
Reproducible in safe mode.

Message Pane enabled.
Selected 16 messages in the Thread Pane.
Went to the Message Pane and can only see two messages.
Comparing it with 78.7.0 I see the scroll bar is missing in the Message Pane.

Comment 3

[Kalvin Lee]

• I don't see similar issues with Firefox (my stable build is a bit behind at 84.0.2, but Nightly doesn't exhibit any similar symptoms).
• Yes, the symptoms also happen in safe mode.
• Walt's comment is a mix-and-match for me: I am also missing the scroll bar in the message pane, but the message pane does appear to collect all selected messages for aggregate display (if I scroll down with Space, anyway).

Comment 4

[WaltS48 [:walts48]]

Didn't know you could use the Space bar.

It also works for me and I see all selected messages for aggregate display.

Comment 5

[Kalvin Lee]

mozregression bisect suggests one of these changes as the culprit. I'm trying to build from these changes (starting from good revision 30b39201c92fc9ceb80468361be566f3e2f5e17b) to verify this.

Comment 6

[Magnus Melin [:mkmelin]]

This would be from bug 1572062

Comment 8

[Magnus Melin [:mkmelin]]

Attachment: bug1689934_multimsgscroll-missing.patch

The overflow part is understandable.

I don't understand why the subjects become non-clickable. Somehow it's due to messenger.css setting :root,body height to 100%; I need to unset the height for root, otherwise they are not clickable. Super weird...

(OTOH, multimessageview.xhtml may not really need messenger.css)

Comment 9

[Richard Marti (:Paenglab)]

Comment on attachment 9207121 [details] [diff] [review]
bug1689934_multimsgscroll-missing.patch

Review of attachment 9207121 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.
Maybe you could do my proposal to show the scrollbar only for the content.

::: mail/base/content/sharedsummary.css
@@ +14,5 @@
>    background-color: var(--body-background-color);
>    color: var(--body-text-color);
>    appearance: none;
> +  height: unset; /* needed to allow elements to react to events */
> +  overflow-y: auto !important;

How about moving the overscroll to `#content` together with adding a height: 100% ?

Then the scrollbar is only on the content without the header.

Comment 10

[Magnus Melin [:mkmelin]]

Attachment: bug1689934_multimsgscroll-missing.patch

Yes, let's do that.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/70445a8d28d8
fix multimessage pane: scrollbars missing and subjects not clickable, after top level html. r=Paenglab

Comment 12

[Kalvin Lee]

Thunderbird Daily built from comment #11 fixes the issue for me on Fedora 33: scrollbars are back and subjects are clickable.