1690098 - Disabled buttons react to hover and click interactions

Status: VERIFIED FIXED

(Thunderbird :: Theme, defect)

Description

[Alessandro Castellani [:aleca]]

Attachment: disabled-button-style.gif

All the disabled buttons in theamable dialogs started showing a visual feedback when hovered of clicked, at least on Linux as I haven't tested it in other platforms.

This seems to be a regression affecting also 78 as it wasn't happening when these elements were styled in previous bugs, during the initial implementation of theamable dialog styles.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1690098-disabled-buttons.patch

Ah, my bad. I did bad work in bug 1650789. I thought the styles applies only to the buttons in notifications and in AB there no disabled buttons exist.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: 1690098-disabled-buttons.patch

This time really working.

Comment 3

[Alessandro Castellani [:aleca]]

Comment on attachment 9200533 [details] [diff] [review]
1690098-disabled-buttons.patch

Review of attachment 9200533 [details] [diff] [review]:
-----------------------------------------------------------------

This fixes the issue for those buttons but it interferes with the `.btn-hub:hover` declaration of the Account Central.
Maybe those classes should be rewritten as `button.btn-hub:hover` to naturally override the default class, rather than using the `!important` flag for background and border color.

Also, this issue makes me think that maybe we might be potentially affecting other buttons that are styled differently throughout the UI, since we're using the `button` element name as CSS selector, and that has a higher hierarchy.

Comment 4

[Richard Marti (:Paenglab)]

Attachment: 1690098-disabled-buttons.patch

This fixes the .btn.hub issue. I skimmed the other buttons and found no similar issue. The calendar-daypicker wasn't affected by this patch but I fixed it too.

Comment 5

[Alessandro Castellani [:aleca]]

Comment on attachment 9200606 [details] [diff] [review]
1690098-disabled-buttons.patch

Review of attachment 9200606 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks for inspecting the other buttons.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ecdece9e242c
Stop showing hover and active on disabled buttons. r=aleca

Comment 7

[Richard Marti (:Paenglab)]

Comment on attachment 9200606 [details] [diff] [review]
1690098-disabled-buttons.patch

[Approval Request Comment]
Regression caused by (bug #): bug 1650789
User impact if declined: disabled buttons give unwanted feedback
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9200606 [details] [diff] [review]
1690098-disabled-buttons.patch

[Triage Comment]
Approved for beta

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 86.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/3f086caeaab6

Comment 10

[WaltS48 [:walts48]]

Disabled buttons no longer react to hover and clicks in my tests of 86.0b2 on Windows 10 and Fedora 33 Workstation.

Comment 11

[Wayne Mery (:wsmwk)]

Comment on attachment 9200606 [details] [diff] [review]
1690098-disabled-buttons.patch

[Triage Comment]
Approved for esr78

Comment 12

[Rob Lemley [:rjl]]

Thunderbird 78.8.0:
https://hg.mozilla.org/releases/comm-esr78/rev/4cdc02a8c7b0

Comment 13

[WaltS48 [:walts48]]

Works for me in my tests of the 78.8.0 release candidate on Fedora 33 Workstation and Windows 10.