1690101 - Spellcheck doesn't re-run when changing language, console errors also on Spelling button

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[juraj.masiar]

Attachment: Screenshot 2021-02-01 21.50.58.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:86.0) Gecko/20100101 Firefox/86.0

Steps to reproduce:

I've just tried to change language from EN to SK (Slovak) while writing an email but it didn't worked.
It worked after I changed focus within the window.
I've noticed every time I tried to change the language it will throw an error in the Error Console (see the image)

Uncaught TypeError: gSpellChecker.mInlineSpellChecker is null
    ComposeChangeLanguage chrome://messenger/content/messengercompose/MsgComposeCommands.js:5355
    ChangeLanguage chrome://messenger/content/messengercompose/MsgComposeCommands.js:5383
    oncommand chrome://messenger/content/messengercompose/messengercompose.xhtml:1
MsgComposeCommands.js:5355:24

I can't really reproduce it but it for sure didn't happened ever before. Maybe regression in 86?

Comment 1

[Wayne Mery (:wsmwk)]

related to Bug 1688551 - inline spell checking suggestions MIA since tb-fission ?

Comment 2

[Thomas D. (:thomas8)]

I got lots of this error when just trying to click on the spellcheck button:

NS_ERROR_NOT_AVAILABLE: Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsIDocShell.domWindow] browsing-context.js:390
get window resource://devtools/server/actors/targets/browsing-context.js:390
_getWindowForBrowserConsole resource://devtools/server/actors/webconsole.js:274
get global resource://devtools/server/actors/webconsole.js:257
makeDebuggeeValue resource://devtools/server/actors/webconsole.js:497
arguments resource://devtools/server/actors/webconsole.js:2070
map self-hosted:221
prepareConsoleMessageForRemote resource://devtools/server/actors/webconsole.js:2069
onConsoleAPICall resource://devtools/server/actors/webconsole.js:1794
onConsoleAPICall self-hosted:1177
observe resource://devtools/server/actors/webconsole/listeners/console-api.js:94
CS_recordEvent resource://gre/modules/ConsoleAPIStorage.jsm:123
reportException resource://devtools/shared/ThreadSafeDevToolsUtils.js:82
reportDebuggerHookException resource://devtools/server/actors/utils/make-debugger.js:93
doCommand chrome://messenger/content/messengercompose/ComposerCommands.js:1393
goDoCommand chrome://global/content/globalOverlay.js:101
oncommand chrome://messenger/content/messengercompose/messengercompose.xhtml:1

Comment 3

[Geoff Lankow (:darktrojan)]

Yes I'm aware, but too busy to look at it yet.

Comment 4

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1690101 - Fix several things wrong with spell checking during compose. r?mkmelin

Fixes changing the language of the spell checker and the state of the spell checker as displayed in the UI.

The problems arose because gSpellChecker as used by the compose code differs from gSpellChecker as used by the context menu code.
I've fixed that by getting the checker directly from the editor whenever the compose code needs it.

Depends on D105258

Comment 5

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1690101 - Test spell checking in the message composition window. r?mkmelin

Depends on D105259

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/828046b1a4e5
Fix several things wrong with spell checking during compose. r=mkmelin
https://hg.mozilla.org/comm-central/rev/33d452b075b3
Test spell checking in the message composition window. r=mkmelin