1695478 - [localized 87.0b1 only] When composing with pre-filled recipients (reply/auto-cc/bcc etc.), any address is duplicated three times (2 pills, 1 plaintext address), Send disabled - Uncaught exceptions: spellcheck

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect, P1)

Description

[halle_saale]

Attachment: bug.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:87.0) Gecko/20100101 Thunderbird/87.0

Steps to reproduce:

I reply to a mail.

Actual results:

In the "To" line, the mail address of the receiver is written three times.

Expected results:

The mail address should be written only one time.

Comment 1

[Andre Klapper]

Does this happen with every email that you reply to? Or only a specific one? If it's specific, then please provide a test case.

Comment 2

[halle_saale]

No, that happens always!

Comment 3

[Thomas D. (:thomas8)]

Hallo halle_saale - leider nicht reproduzierbar... und ganz bestimmt kein TB bug! Guess we'd see many more reports if this was a TB bug.
Wfm on TB 78.8.0 (32-Bit) and 88.0a1 (2021-02-28) (64-bit) (reported against 87).

• Does this still happen after ≡ > Help > Restart with Add-ons Disabled… (Hilfe > mit deaktivierten Add-ons neu starten)?

(In reply to halle_saale from comment #2)

No, that happens always!

• Have you tried replying to different mails from different senders and this problem happens for all of them?
• Start error console (Strg+Umschalt+J), click dustbin icon (oben links) to clear, then Ctrl+R - anything in error console after that when this happens?
• Your screenshot shows 2 recipient items (pills), but the third address has not yet been changed to a pill (still plain text). Are you seeing this combination every time it happens? (Tbh, that's another indication that this cannot be a TB bug, almost technically impossible to get into that state, and it's very volatile as that address would pillify as soon as focus is in body).
• Where is focus in write window after you click reply button or press Ctrl+R?

Comment 4

[halle_saale]

Auf Deutsch geht es vielleicht einfacher:
Ich habe seit dem Umstellen auf die neue Betaversion viele verschiedene Mails geschrieben. Es ist immer dasselbe Verhalten. Genau wie im Screenshot: Zwei Empfänger sind fest, der dritte als Schrift. Ich habe weder Addons installiert, noch großartig etwas anderes am PC verändert/installiert.
Das MUSS definitiv etwas mit TB zu tun haben, denn vorher funktionierte es einwandfrei und dieses Verhalten trat noch nie auf!

Comment 5

[halle_saale]

Attachment: Fehlerkonsole

Comment 6

[Jens Müller (:tessarakt)]

See also bug 1695536. Something similar happens without replying, by just composing a new message.

Comment 7

[Jens Müller (:tessarakt)]

Does this still happen after ≡ > Help > Restart with Add-ons Disabled… (Hilfe > mit deaktivierten Add-ons neu starten)?

Btw, the "Restart" button in that dialog for me closes the dialog, but doesn't actually restart ... Should I report a new bug for that?

Comment 8

[Jens Müller (:tessarakt)]

The only addon I had installed was "Quick Folder Move". After disabling that, the bug still occurs.

Comment 10

[Jens Müller (:tessarakt)]

I now installed a non-localized (English) TB 87.0b1, and the issue does not occur there.

Comment 11

[Thomas D. (:thomas8)]

(In reply to halle_saale from comment #4)

Auf Deutsch geht es vielleicht einfacher:
Ich habe seit dem Umstellen auf die neue Betaversion viele verschiedene Mails geschrieben. Es ist immer dasselbe Verhalten. Genau wie im Screenshot: Zwei Empfänger sind fest, der dritte als Schrift. Ich habe weder Addons installiert, noch großartig etwas anderes am PC verändert/installiert.
Das MUSS definitiv etwas mit TB zu tun haben, denn vorher funktionierte es einwandfrei und dieses Verhalten trat noch nie auf!

Translation:
Since updating to new beta version, I have written many messages, and the behaviour is always the same. Exactly as in screenshot: Two pillified recipients, third one as plain text. I don't have addons, nor any other remarkable changes or installations on this machine.
So it MUST have something to do with TB, as it was working flawlessly before and this behaviour never occured!

Comment 12

[dannywiz2002]

Attachment: BUG 870.b1 - 2021-03-01 10-15-10

Comment 13

[dannywiz2002]

Exactly the same error here, since the last update to a Italian localized 87.0b1 update. The previous 86.0b3 worked fine.

Comment 14

[Thomas D. (:thomas8)]

(In reply to Jens Müller (:tessarakt) from comment #10)

I now installed a non-localized (English) TB 87.0b1, and the issue does not occur there.

Wfm on 87.0b1 (32-bit)-EN on Win10 - maybe it's other locales as Jens said in comment 10.
But I actually remember having seen this type of recipient chaos for some days somewhere.

The second error message involving addRecipientsToIgnoreList() in screenshot of attachment 9205971 [details] might be related.

Comment 15

[Thomas D. (:thomas8)]

Alice, could you find the regression window?
Geoff, Alex, any insights?

Confirming exactly as described in comment 0 and depicted in screenshots.
Does not affect en-US localization, only other localizations of 87.0b1 (64-Bit).
This makes such localizations very annyoing to use (useless-UI).
Maybe some upstream regression.

There are two spellcheck-related error messages which might explain why it only occurs for localized builds.

Uncaught
Exception { name: "NS_ERROR_FAILURE", message: "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIEditor.getInlineSpellChecker]", result: 2147500037, filename: "chrome://messenger/content/messengercompose/MsgComposeCommands.js", lineNumber: 9022, columnNumber: 0, data: null, stack: "enableInlineSpellCheck@chrome://messenger/content/messengercompose/MsgComposeCommands.js:9022:36\nInitEditor@chrome://messenger/content/messengercompose/MsgComposeCommands.js:8844:25\nobserve@chrome://messenger/content/messengercompose/MsgComposeCommands.js:3792:9\n", location: XPCWrappedNative_NoHelper }
MsgComposeCommands.js:9022

Uncaught
Exception { name: "NS_ERROR_FAILURE", message: "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIEditor.getInlineSpellChecker]", result: 2147500037, filename: "chrome://messenger/content/messengercompose/MsgComposeCommands.js", lineNumber: 5209, columnNumber: 0, data: null, stack: "addRecipientsToIgnoreList@chrome://messenger/content/messengercompose/MsgComposeCommands.js:5209:36\nrecipientAddPills@chrome://messenger/content/messengercompose/addressingWidgetOverlay.js:778:28\nCompFields2Recipients@chrome://messenger/content/messengercompose/addressingWidgetOverlay.js:147:26\nComposeFieldsReady@chrome://messenger/content/messengercompose/MsgComposeCommands.js:2757:24\nNotifyComposeFieldsReady@chrome://messenger/content/messengercompose/MsgComposeCommands.js:503:5\n", location: XPCWrappedNative_NoHelper }
MsgComposeCommands.js:5209

Comment 16

[Thomas D. (:thomas8)]

Attachment: Screenshot: Several prefilled addresses duplicated (auto-cc or reply-all)

The recipient chaos increases the more prefilled addresses you have - should be fixed asap.

Comment 18

[Alessandro Castellani [:aleca]]

I'm keeping track of this but I have no idea what changed in 87 with localized versions.

Comment 19

[Thomas D. (:thomas8)]

Recipient input is completely broken on localized versions of 87.0b1 Beta.

More severe symptoms which I found on duplicate bug 1695629:

• Trying to clear the mess, clicking on plaintext addresses or pills will often add even more recipients.
• Tab whilst the plaintext duplicate is around will also add more duplicates.
• Clearing them all, then retyping one, press TAB or Enter and it adds the plaintext duplicate again. At least you can manually delete that, but by that time, your tempers will be boiling and you may not be able to focus hard enough to get this right.

Comment 20

[Geoff Lankow (:darktrojan)]

It's failing because there are no dictionaries installed. I'm not sure why there are no dictionaries installed (I guess we don't ship them) but it should not fail because of that.

Comment 21

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1695478 - Fix compose spell checker when no dictionaries are installed. r?aleca

Adds a function to return the spell checker or null if there are no dictionaries available.

I've also rearranged the context menu spell check initialisation code to match that of nsContextMenu.js, and added the "undo add to dictionary" item.

Comment 22

[halle_saale]

Confirmation: After having installed the German dictionary, TB works again as expected!

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6ccf34586122
Fix compose spell checker when no dictionaries are installed. r=aleca

Comment 25

[Ali Savas]

I was also able to solve the problem by installing the dictionary. I just wanted to share this as a quick confirmation.

Comment 28

[Wayne Mery (:wsmwk)]

uplift to beta very much wanted - assuming it is relatively safe

Comment 32

[Rob Lemley [:rjl]]

Comment on attachment 9206234 [details]
Bug 1695478 - Fix compose spell checker when no dictionaries are installed. r?aleca

[Triage Comment]
Approved by wsmwk in #maildev on Matrix.

Comment 33

[Rob Lemley [:rjl]]

Thunderbird 87.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/a60c56ed594f