1690396 - mix-blend-mode may be broken with raster roots

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Lee Salzman [:lsalzman]]

This seems to manifest as fuzziness in layout/reftests/css-blending/mix-blend-mode-and-filter.svg like it is sampling something in the filter at a wrong offset, once SWGL enabled KHR_advanced_blend_equation support. As per Glenn on matrix:

I'm not entirely surprised, I'm finding it difficult to understand how any of the mix-blend stuff works in the presence of raster roots (which svg filters introduce) at the moment!
(well, it doesn't work - I've already been able to create simple test cases that are completely broken with the existing impl)

Comment 1

[Glenn Watson [:gw]]

I am working on this now, as it needs to be fixed to unblock the mix-blend optimization work I'm doing anyway.

Comment 2

[Glenn Watson [:gw]]

Attachment: Bug 1690396 - Refactor mix-blend-mode impl to work correctly with raster roots.

This fixes incorrect rendering when either the source or backdrop
tasks establish a raster root.

By design, it also changes mix-blend backdrop readbacks to work in
a way that can handle readbacks from picture cache tiles, which is
a follow up optimization being worked on.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ddd89e758a23
Refactor mix-blend-mode impl to work correctly with raster roots. r=nical

Comment 4

[Dorel Luca [:dluca]]

Backed out changeset ddd89e758a23 (bug 1690396) for Wrench failures. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer?job_id=328786345&repo=autoland&lineNumber=13437

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=arKd_SyOQ5Gg7udz2K5Sdg.0&revision=ddd89e758a23d130d6967c9ac71676fd540ad011

Backout:
https://hg.mozilla.org/integration/autoland/rev/097886f855f15b0d312bfcd763d4c2cccc2febf7

Comment 5

[Glenn Watson [:gw]]

Oops, I had already found and fixed this failure - but forgotten to push the updated patch to phab. Should be fixed now, thanks!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0788e77d2d62
Refactor mix-blend-mode impl to work correctly with raster roots. r=nical

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/0788e77d2d62

Comment 8

[Natalia Csoregi [:nataliaCs]]

Backed out for causing Bug 1690846

backout: https://hg.mozilla.org/mozilla-central/rev/f259675c88bf6bb78eed73238ba942804417c750

Comment 9

[Glenn Watson [:gw]]

Thanks for backing out! Do we have any URLs from the crash reports? I haven't managed to repro locally yet.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6b775dfe44a9
Refactor mix-blend-mode impl to work correctly with raster roots. r=nical

Comment 11

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/6b775dfe44a9