1690564 - Hide pocket context menu items if not signed in to pocket

Status: RESOLVED WONTFIX

(Firefox :: Pocket, enhancement)

Description

[:Gijs (he/him)]

We should hide the "save to pocket" and "save link to pocket" context menu items when the user is not signed in to pocket.

Note that pocket sign-in state is dependent on (web) cookie storage, and so we should ideally check if the user is in permanent private browsing, in which case we should probably still show the items (or they will never show up there unless the user signs in using the toolbar button or by opening the pocket website every time they use pocket -- and even then it might not work because of our separate cookie storage jars). See also bug 1668803 and bug 1166253, bug 1261378, and bug 1565676 (some of which are dupes of each other, I think. Will sort that out in a bit.)

Alternatively, we would need to store Pocket sign-in state somewhere else. This is explicitly not in scope for the proton team right now, but if the Pocket team has time to tackle this in time for 89 that would of course be great. :-)

Comment 1

[:Gijs (he/him)]

(In reply to :Gijs (he/him) from comment #0)

See also bug 1668803 and bug 1166253, bug 1261378, and bug 1565676 (some of which are dupes of each other, I think. Will sort that out in a bit.)

Actually, seems like a bunch of them are all subtly different, but all consequences of the same root problem (ie where we store pocket login state).

Comment 2

[Jessilyn Davis]

Thanks :Gijs! NI'ing Priya our PM to consider in our upcoming nightly planning.

Comment 3

[:Gijs (he/him)]

(In reply to Jessilyn Davis from comment #2)

Thanks :Gijs! NI'ing Priya our PM to consider in our upcoming nightly planning.

Hi! There is some time pressure involved here (we're trying to get all the proton-related changes for context menus landed in nightly in the next 3 weeks). When is the planning happening, and when would the work happen? It would be great if the pocket team could help here, but if that is not possible we will need to find someone else to do the work.

Comment 4

[Priya Ganapati]

the current experience is that a user not signed into Pocket sees the "save link to pocket" as part of the context menu. Clicking on that takes them to a sign up flow asking them to sign up. If we remove that context menu item, discovery (that Pocket as a feature exists) will become impossible for new/potential users.
With that in mind, i would like to further understand the thinking around why it should be removed before we schedule any work.

Comment 5

[Blake Winton (:bwinton) (:☕️)]

Just got a note that we're going to keep this item as it is for Proton, so I'm closing this bug, and we can file a new one if we decide to change things later. 🙂