1690900 - Convert email to task/event is broken since 2021-01-20

Status: VERIFIED FIXED

(Thunderbird :: General, defect)

Description

[Danny Colin [:sdk]]

Step to reproduce

0. Right-click on an email in the message list
1. Choose "Convert To"
2. Choose "Event" or "Task"

Expected behavior

A new window to configure the event or task should open

Actual behavior

Nothing happens.

Additional information

I did a mozregression and this regression has been introduced by:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=47627b7a5b34d04816233abe24bf4051b8ac807c&tochange=be365d09c14b55f717bdf633cf48dbb6a27a3754

I also tried with browser.tabs.remote.autostart set to false but the issue persists.

Comment 1

[Alfred Peters [:infofrommozilla]]

Curious, there is already a bug report from mid-December: Bug 1682895

Comment 2

[Alfred Peters [:infofrommozilla]]

Error Console:
| Lightning: Your installed Lightning only includes a single locale, extracting event info from other languages is likely inaccurate. You can install Lightning from addons.mozilla.org manually for multiple locale support. calExtract.jsm:47

Curious warning, but it always comes up together with the next error message.

| Uncaught ReferenceError: GetMessagePaneFrame is not defined
| extractFromEmail chrome://calendar/content/calendar-extract.js:118
| oncommand chrome://messenger/content/messenger.xhtml:1
| calendar-extract.js:118:15

Comment 3

[Danny Colin [:sdk]]

(In reply to Alfred Peters from comment #1)

Curious, there is already a bug report from mid-December: Bug 1682895

Looks more like a coincidence. The application doesn't crash in my case.

Curious warning, but it always comes up together with the next error message.

I only get the Uncaught ReferenceError: GetMessagePaneFrame is not defined on my side and AFAIK it'd make sense if it's related to e10s. I'm guessing it prevents communication between both parts of the code.

Comment 4

[Alfred Peters [:infofrommozilla]]

(In reply to Danny Colin [:sdk] from comment #0)

I did a mozregression and this regression has been introduced by:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=47627b7a5b34d04816233abe24bf4051b8ac807c&tochange=be365d09c14b55f717bdf633cf48dbb6a27a3754

Let's see what Geoff Lankow has to say about it. Geoff?

Comment 5

[Geoff Lankow (:darktrojan)]

I removed GetMessagePaneFrame, so that'll be why it's not working!

Comment 6

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1690900 - Fix converting messages to events. r?mkmelin

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/9aa3f607e4b6
Fix converting messages to events. r=mkmelin

Comment 10

[Geoff Lankow (:darktrojan)]

Comment on attachment 9201967 [details]
Bug 1690900 - Fix converting messages to events. r?mkmelin

[Approval Request Comment]
Regression caused by (bug #): tb-fission
User impact if declined: converting mail to events won't work
Testing completed (on c-c, etc.): landed 3 days ago
Risk to taking this patch (and alternatives if risky): no

Comment 11

[Wayne Mery (:wsmwk)]

Comment on attachment 9201967 [details]
Bug 1690900 - Fix converting messages to events. r?mkmelin

[Triage Comment]
Approved for beta

Comment 13

[Rob Lemley [:rjl]]

Thunderbird 86.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/43f193c4d26b

Comment 14

[WaltS48 [:walts48]]

TB 86.0b3 on Windows 10

Followed reporters STR for a credit card payment due on 02/20

The Event dialog opened with a start date of 2/20 and an end date of 2/28.

Converting the email to a task the start date was 02/13 @ 5:23 AM, due on 2/21@ 5:23 AM.

The same occurs using the Fedora supplied 78.7.0 on Fedora 33.

Since I never use this is that the expected result?

Comment 15

[Danny Colin [:sdk]]

(In reply to WaltS48 [:walts48] from comment #14)

Since I never use this is that the expected result?

On my side, both set the start date to today's date. Maybe there's something special with your email. Maybe there's something similar to "add this event to your calendar" banner you get with google calendar invitation.

Oh and btw, darktrojan patch fixed my issue :)

Comment 16

[WaltS48 [:walts48]]

Not a Google invite, but a bank email with the due date of my credit card payment.

Event starts on the Due date, task on the date I received the email. Both are editable.

Since your issue is resolved.