Closed Bug 1691315 Opened 3 years ago Closed 3 years ago

Rewrite `X.setAttribute("hidden", Y)` to `X.hidden = Y` in devtools/startup

Categories

(DevTools :: General, task)

Product:
DevTools
Component:
General
Type:
task

Tracking

(firefox87 fixed)

Status:
RESOLVED FIXED
Milestone:
87 Branch
Tracking Flags:
Tracking Status
firefox87 --- fixed

People

(Reporter: ntim, Assigned: ntim)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1691315 - Replace .setAttribute("hidden", X) usages in devtools/startup. r=nchevobbe
48 bytes, text/x-phabricator-request
Details | Review

+++ This bug was initially created as a clone of Bug #1691314 +++

https://searchfox.org/mozilla-central/search?q=.setAttribute%28%22hidden%22&path=devtools%2Fclient&case=false&regexp=false

.setAttribute("hidden", "true"); -> .hidden = true;
.setAttribute("hidden", true); -> .hidden = true;

.setAttribute("hidden", "false"); -> .hidden = false;
.setAttribute("hidden", false); -> .hidden = false;

Assignee: nobody → ntim.bugs
Status: NEW → ASSIGNED
Blocks: 1691321
No longer blocks: 1592799
Attachment #9201688 - Attachment description: Bug 1691315 - Replace .setAttribute(hidden, X) usages in devtools/startup. r=nchevobbe → Bug 1691315 - Replace .setAttribute("hidden", X) usages in devtools/startup. r=nchevobbe
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/d706a12d0b85
Replace .setAttribute("hidden", X) usages in devtools/startup. r=nchevobbe

https://hg.mozilla.org/mozilla-central/rev/d706a12d0b85

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox87: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: