1691414 - Refactor WebDriver session module to be shareable with WebDriver BiDi

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Once the Session specific code in Marionette has been extracted to a dedicated Session module (bug 1691402), this module and all necessary dependencies have to be moved to /remote/shared/.

For this bug it should be enough to just make the module available at the new location, and import it in Marionette.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

While working on bug 1691402 we noticed that more work is necessary to actually allow both Marionette and Remote Agent to share the same WebDriver session.

Given that just moving the JS module to a different location in the tree isn't work that requires its own bug, I suggest we expand it to also include the investigation and refactoring to make the current instance independent from the driver classes.

Given that the complexity of the bug clearly increases lets re-evaluate that in the next triage meeting.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1691414 - [remote] Share WebDriver session between Marionette and WebDriver BiDi.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1691414 - [remote] Extract WebDriver capabilities specific classes into their own Capability module.

Depends on D117127

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6df75d4ea57e
[remote] Share WebDriver session between Marionette and WebDriver BiDi. r=webdriver-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/ae8cc0a1bb6b
[remote] Extract WebDriver capabilities specific classes into their own Capability module. r=webdriver-reviewers,jdescottes

Comment 5

[Dorel Luca [:dluca]]

Backed out 2 changesets (bug 1691414) for Documentation failures. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer?job_id=342168009&repo=autoland&lineNumber=851

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=ae8cc0a1bb6b17fd6767da2f040f2861fdcb9491

Backout:
https://hg.mozilla.org/integration/autoland/rev/2611cc88785ea67296c2bfb074022b8352824992

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

That documenation issue went through unnoticed because the documentation only gets built when actual rst files are getting changed. This didn't happen in this case, and as such was not visible on try.

Given that we are not sure about the usefulness of the internal docs, we decided to just remove those documentation files that are related to JS modules that are getting moved to /remote/shared for now. We will try to find a solution for possible future use over on bug 1694136.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e95d0824aaaa
[remote] Share WebDriver session between Marionette and WebDriver BiDi. r=webdriver-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/115a90741d67
[remote] Extract WebDriver capabilities specific classes into their own Capability module. r=webdriver-reviewers,jdescottes

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/e95d0824aaaa
https://hg.mozilla.org/mozilla-central/rev/115a90741d67