Closed Bug 1691414 Opened 7 months ago Closed 3 months ago

Refactor WebDriver session module to be shareable with WebDriver BiDi

Categories

(Remote Protocol :: WebDriver BiDi, task, P2)

task
Points:
8

Tracking

(firefox91 fixed)

RESOLVED FIXED
91 Branch
Tracking Status
firefox91 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

()

Details

(Whiteboard: [bidi-m1-mvp])

Attachments

(2 files)

Once the Session specific code in Marionette has been extracted to a dedicated Session module (bug 1691402), this module and all necessary dependencies have to be moved to /remote/shared/.

For this bug it should be enough to just make the module available at the new location, and import it in Marionette.

Summary: Extract session specific code from driver.js into a dedicated session module → Move session related modules from Marionette to Remote Protocol
Blocks: 1691446
Component: Agent → WebDriver BiDi
Points: --- → 2

While working on bug 1691402 we noticed that more work is necessary to actually allow both Marionette and Remote Agent to share the same WebDriver session.

Given that just moving the JS module to a different location in the tree isn't work that requires its own bug, I suggest we expand it to also include the investigation and refactoring to make the current instance independent from the driver classes.

Given that the complexity of the bug clearly increases lets re-evaluate that in the next triage meeting.

Points: 2 → ---
Component: WebDriver BiDi → Marionette
Product: Remote Protocol → Testing
Summary: Move session related modules from Marionette to Remote Protocol → Refactor WebDriver session module to be shareable with WebDriver BiDi
Points: --- → 8
Component: Marionette → WebDriver BiDi
Product: Testing → Remote Protocol
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6df75d4ea57e
[remote] Share WebDriver session between Marionette and WebDriver BiDi. r=webdriver-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/ae8cc0a1bb6b
[remote] Extract WebDriver capabilities specific classes into their own Capability module. r=webdriver-reviewers,jdescottes

That documenation issue went through unnoticed because the documentation only gets built when actual rst files are getting changed. This didn't happen in this case, and as such was not visible on try.

Given that we are not sure about the usefulness of the internal docs, we decided to just remove those documentation files that are related to JS modules that are getting moved to /remote/shared for now. We will try to find a solution for possible future use over on bug 1694136.

Flags: needinfo?(hskupin)
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e95d0824aaaa
[remote] Share WebDriver session between Marionette and WebDriver BiDi. r=webdriver-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/115a90741d67
[remote] Extract WebDriver capabilities specific classes into their own Capability module. r=webdriver-reviewers,jdescottes
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in before you can comment on or make changes to this bug.