1691481 - Share Marionette's errors module with WebDriver BiDi

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The errors module from Marionette needs to be moved to the Remote Protocol code base so that it can be shared with the WebDriver BiDi implementation.

Comment 1

[Julian Descottes [:jdescottes]]

The Error module from marionette relies on the format.js module, which is almost duplicated in remote already.

However they both use different preferences to decide how to truncate logs:

• marionette's format.js uses marionette.log.truncate
• remote's Format.jsm uses remote.log.truncate

We should probably address this issue before we attempt to move the module?
We could do the following:

• remove marionette's format.js and always use Format.jsm (I just checked the modules are identical)
• update remote's Format.jsm to check both preferences
• communicate about marionette.log.truncate being phased out in favor of remote.log.truncate
• eventually stop checking marionette.log.truncate in remote's Format.jsm (after N releases....)

Also another question about all the bugs related to moving modules to /remote. I think we still have an issue with /remote not being packaged in Android? Should all those bugs be blocked on https://bugzilla.mozilla.org/show_bug.cgi?id=1676803

Comment 2

[Julian Descottes [:jdescottes]]

Clearing the ni?

Filed Bug 1700390 to discuss each preference in details.
For now I will try to reuse Format.jsm in marionette, which will also require to build remote/ on Android.

Comment 3

[Julian Descottes [:jdescottes]]

So far I am blocked on Bug 1676803 (building remote on Android). I didn't find a way to properly include remote/ on Android yet.

I want to focus on the architecture bits for BiDi, so I will unassign from bugs which are not urgent to address for now.
However I realized that moving some modules will also break our documentation. We generate automated documentation page for some of the modules we intend to move (eg error.rst, format.js).

We will need to decide what we do about this documentation. Split it between marionette and remote?

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Yes, we would have to cross-reference but the problem is also that it wouldn't be build if remote agent is not enabled for the build. I hit similar problems on bug 1693993 when I tried to move all Marionette code over to /remote. Looks like we have to combine both build options into a single ENABLE_WEBDRIVER one.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I filed bug 1700910 for that. We can discuss it in the next triage meeting.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1691481 - [remote] Share Marionette's errors module with WebDriver BiDi.

The WebDriver BiDi specification relies on the same
error types as WebDriver HTTP. As such the existing
module needs to be shared.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fd9895e3c184
[remote] Share Marionette's errors module with WebDriver BiDi. r=webdriver-reviewers,jdescottes

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/fd9895e3c184