1693993 - Move Marionette server code from /testing/marionette to /remote

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, task, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

All the WebDriver BiDi code will be located under /remote, whereby the WebDriver implementation can be found under /testing/marionette. It would be helpful to have all the code close to each other, which also makes sharing of modules between all of the components easier.

Note that code under /testing is also client and harness code only. As such having the Marionette component located under this folder doesn't even make sense.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Given that xpcshell tests will also be moved over, lets wait for bug 1690475 before trying to move all that code.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Btw. when we do that we should make sure to add atom.js to /tools/rewriting/ThirdPartyPaths.txt.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I did a quick test today and it looks like that this will work. As such I will take it.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1693993 - [marionette] Move Marionette server code to /remote/marionette.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

It wasn't too heavy to do. Reducing points to 3.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

There is a build failure for Android only:
https://treeherder.mozilla.org/jobs?repo=try&revision=083d41b816a4bf6b11c295b1e6c3bb79a4735af5&selectedTaskRun=JOlQlnsTR4iOBT3123J4YA.0

/builds/worker/checkouts/gecko/security/manager/ssl/nsCertOverrideService.cpp:21:10: fatal error: 'nsIMarionette.h' file not found

Agi, do you know what I would have to specifically change in some build config to make it work on Android? All the changes I did so far work fine for desktop, but something I seem to overlook for Android. Thanks!

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Maybe it's indeed bug 1676803? Given that Marionette would be located under /remote now, and the Remote Agent isn't enabled on Android yet the contained moz.build files aren't processed, and as such the Marionette component not build.

Comment 8

[[ex-Mozilla] Agi Sferro | :agi]

(In reply to Henrik Skupin (:whimboo) [⌚️UTC+1] from comment #7)

Maybe it's indeed bug 1676803? Given that Marionette would be located under /remote now, and the Remote Agent isn't enabled on Android yet the contained moz.build files aren't processed, and as such the Marionette component not build.

I believe that's correct, I don't think the remote folder is built on Android: https://searchfox.org/mozilla-central/source/toolkit/components/moz.build#10-12 at least I don't see MOZ_HAS_REMOTE in my build or on m-c.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Ok, lets see if bug 1676803 turns out to be easy. As such marking it blocking the move of Marionette code.

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Bug 1676803 can't be done soon. As such we should delay this work until the BiDi transport layer including the BiDi Session implementation is ready.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/37f2f9ef6ef8
[marionette] Move Marionette server code to /remote/marionette. r=remote-protocol-reviewers,marionette-reviewers,jdescottes,webdriver-reviewers

Comment 12

[Alexandru Michis [:malexandru]]

Backed out changeset 37f2f9ef6ef8 (bug 1693993) for containing unreviewed changes.
Backout link: https://hg.mozilla.org/integration/autoland/rev/a8875377a5a397b463b9e33c226e573354c58ed2

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/58f5c0d1d873
[marionette] Move Marionette server code to /remote/marionette. r=remote-protocol-reviewers,marionette-reviewers,jdescottes,webdriver-reviewers

Comment 14

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/58f5c0d1d873