1700392 - Replace usage of marionette format.js by remote/shared/Format.jsm

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P2)

Description

[Julian Descottes [:jdescottes]]

The two modules are identical, except for the preference they use to truncate or not messages:

• remote.log.truncate for the remote/shared module
• marionette.log.truncate for the marionette module

Removing format.js in favor of remote/shared/Format.jsm would help moving other modules (eg errors.js) to remote/shared.

Comment 1

[Julian Descottes [:jdescottes]]

Not urgent unassigning to focus on the BiDi architecture.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Maybe a dupe of bug 1693993, but lets see.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to Julian Descottes [:jdescottes] from comment #0)

The two modules are identical, except for the preference they use to truncate or not messages:

• remote.log.truncate for the remote/shared module
• marionette.log.truncate for the marionette module

Similar to the build flag we could rename these preferences to webdriver.log.[level|truncate]. That way it will be easier to maintain. When doing that we also have to update geckodriver so it uses the new ones, but also keeps setting the old ones for backward compatibility reasons.

Julian, what do you think? If you agree we should get the new pref names added with the next geckodriver release, and afterward we can make the change on this bug.

Comment 4

[Julian Descottes [:jdescottes]]

Agreed, having unique prefs webdriver.log.truncate & webdriver.log.level is the way to go here. Let's make the change to geckodriver as soon as we can.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Actually marionette.log.truncate is not used in geckodriver. As such we should not be blocked on making this change to webdriver.log.truncate and we could immediately start merging both modules. But maybe it's wise to wait and update all the preferences at once.

Comment 6

[Julian Descottes [:jdescottes]]

Let's discuss during our next triage, bug flagging as [bidi-m1-mvp] because I think all the effort to create shared modules should be MVP?

Comment 7

[Julian Descottes [:jdescottes]]

Picking this back up while we are handling reviews for MessageHandler patches

Comment 8

[Julian Descottes [:jdescottes]]

Attachment: Bug 1700392 - [remote] Replace usage of marionette format.js by remote/shared/Format.jsm

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ecafeeb0aa81
[remote] Replace usage of marionette format.js by remote/shared/Format.jsm r=webdriver-reviewers,whimboo

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/ecafeeb0aa81