Closed
Bug 1691935
Opened 5 years ago
Closed 5 years ago
Context menu Save Image As is broken again after tb-fission
Categories
(Thunderbird :: General, defect)
Thunderbird
General
Tracking
(thunderbird_esr78 unaffected, thunderbird86 affected)
RESOLVED
FIXED
87 Branch
| Tracking | Status | |
|---|---|---|
| thunderbird_esr78 | --- | unaffected |
| thunderbird86 | --- | affected |
People
(Reporter: mkmelin, Assigned: darktrojan)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
in nsContextMenu.js we used to call this.setTarget(node) which set up imageURL.
We don't do that now (setTarget seems unused), so in saveImage() this.imageURL is undefined and it's all downhill from there.
| Reporter | ||
Updated•5 years ago
|
Assignee: nobody → geoff
status-thunderbird86:
--- → affected
| Assignee | ||
Comment 1•5 years ago
|
||
Replaces two fields that were only set by setTarget and removes setTarget, which is now unused.
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/653d18dfbf42
Fix and test context menu Save Image As. r=mkmelin
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
| Reporter | ||
Updated•5 years ago
|
Target Milestone: --- → 87 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•