1692214 - Hide the Library button by default

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, enhancement, P2)

Description

[Mark Striemer [:mstriemer]]

The contents of the Library menu is now available in the app menu, if users haven't used it in the last 60 days it should be moved from the toolbar to the Customize pane.

See the implementation in bug 1686523 for how to do this.

Comment 1

[Emma Malysz]

Attachment: Bug 1692214, hide library button by default in proton toolbar

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6ce7064d4bf6
hide library button by default in proton toolbar r=mstriemer

Comment 3

[Natalia Csoregi [:nataliaCs]]

Backed out for browser-chrome failures on browser_proton_toolbar_hide_home_and_library_buttons.js

backout: https://hg.mozilla.org/integration/autoland/rev/fa5cac5bb9cd935c766eda292a1801b6f00eb728

push: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=NAOLl7oRSSC2UJvKTvpBbA.0&revision=6ce7064d4bf65c207cbd0416f6e6a00e4d3ef78e&group_state=expanded

failure log: https://treeherder.mozilla.org/logviewer?job_id=330550683&repo=autoland&lineNumber=3076

[task 2021-02-19T19:35:22.079Z] 19:35:22 INFO - TEST-PASS | browser/components/customizableui/test/browser_proton_toolbar_hide_home_and_library_buttons.js | Correctly handles home button - true == true -
[task 2021-02-19T19:35:22.080Z] 19:35:22 INFO - Buffered messages finished
[task 2021-02-19T19:35:22.081Z] 19:35:22 INFO - TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_proton_toolbar_hide_home_and_library_buttons.js | Correctly handles library button - false == true - JS frame :: chrome://mochitests/content/browser/browser/components/customizableui/test/browser_proton_toolbar_hide_home_and_library_buttons.js :: testToolbarButtons :: line 67
[task 2021-02-19T19:35:22.082Z] 19:35:22 INFO - Stack trace:
[task 2021-02-19T19:35:22.083Z] 19:35:22 INFO - chrome://mochitests/content/browser/browser/components/customizableui/test/browser_proton_toolbar_hide_home_and_library_buttons.js:testToolbarButtons:67
[task 2021-02-19T19:35:22.084Z] 19:35:22 INFO - chrome://mochitests/content/browser/browser/components/customizableui/test/browser_proton_toolbar_hide_home_and_library_buttons.js:testButtonRemoval:148
[task 2021-02-19T19:35:22.085Z] 19:35:22 INFO - TEST-PASS | browser/components/customizableui/test/browser_proton_toolbar_hide_home_and_library_buttons.js | Toolbar proton version updated - true == true -

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3b3f13427ea2
hide library button by default in proton toolbar r=mstriemer

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/3b3f13427ea2

Comment 6

[Rares Doghi, Desktop QA]

Hi Mark, The Library menu shouldnt be displayed on a toolbar with a new profile either right ? Or the only scenario where its not displayed is if its a very old profile and the Library menu was not accessed in the last 60 days ??

Right now in our latest Nightly builds the Library menu is still displayed even with new profiles.

Comment 7

[Mark Striemer [:mstriemer]]

It should not be displayed in new profiles. From a local build with browser.proton.toolbar.enabled set to true on first run I don't see the Library button. If it's showing up that would be a bug.

Comment 8

[Florencia Di Ciocco, NI to vbalducci]

Hi, I just tested this, I created a User.js file with user_pref("browser.proton.toolbar.enabled", true);, inserted the file in the user's profile folder before ever running it, and on the first run, I see the library button. I'm on ubuntu 20, on the latest FF nightly.

Comment 9

[Rares Doghi, Desktop QA]

Right , So we do need both of these :

user_pref("browser.proton.enabled", true);
user_pref("browser.proton.toolbar.enabled", true);

I was able to Verify this fix with both of these prefs enabled. Thanks Mark.