1692263 - [macOS] Change keyboard shortcut for Message Security Info from Cmd+Option+S to Cmd+Control+S - Keyboard shortcuts with Alt/Option modifiers don't return different key characters (Alt+S=ß)

Status: RESOLVED FIXED

(Thunderbird :: OS Integration, defect, P2)

Description

[Alessandro Castellani [:aleca]]

I noticed this issue while trying to fix a failing test on macOS for bug 1640760.

It seems that the keyboard shortcuts defined in JavaScript via a document EventLitener "keypress" are not firing in macOS.

To test this out, select a message that has an S/MIME or OpenPGP encryption button visible.
To open the security info panel, ⌘ ⌥ S is the combination (Command, Option, S).
This used to work when we first implemented that shortcut as both myself and Richard tested it on macOS.

Is this a BigSur issue, or maybe a Firefox regression? Or are we doing something completely wrong?

Pinging Tim to see if he has any idea what this might be, and if it might be reproducible also on Firefox.

Comment 1

[Tim Nguyen :ntim]

Do you have a small JS snippet you can share that can be tried in the browser console?

(Also, I'm generally not too familiar with keyboard shortcuts in Firefox, maybe Gijs would be a better person to ask?)

Comment 2

[Alessandro Castellani [:aleca]]

I found the problem, which is a macOS specific issue and not a Firefox issue.

When holding the alt/option key in macOS, keyboard letters are replaced with an ASCII character.
So, on Windows and Linux, Alt + S = S
on macOS, Alt + S = ß

Comment 3

[Alessandro Castellani [:aleca]]

Attachment: 1692263-macos-shortcut.diff

This fixes the shortcut issue on macOS by using the control key instead of the option key.
I also implemented a simple test to keep track of this.
https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=d128452195d312dbfd3e98eac03f2d8c20f56484

Comment 4

[Alessandro Castellani [:aleca]]

Attachment: 1692263-macos-shortcut.diff

A tiny test failure on macOS.
https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=8d0ea371d2789afa94d9fad752737f7067e29159

Comment 5

[Alessandro Castellani [:aleca]]

Attachment: 1692263-macos-shortcut.diff

Making this test work was more annoying than expected.
Sorry for the noise: https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=14b0e2aa9c6049a376b80159d24da7ac182969a7

Comment 6

[Richard Marti (:Paenglab)]

Comment on attachment 9204739 [details] [diff] [review]
1692263-macos-shortcut.diff

Looks good and works on Windows and Mac.

I haven't tested the test but it looks for me okay.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3c1f317b2f62
Fix macOS keyboard shortcut not working for message security popup panel. r=Paenglab