Closed Bug 1692666 Opened 3 years ago Closed 3 years ago

Move "Search [Engine] for '...'" to its own dedicated section (ie separator before + after) in the content context menu

Categories

(Firefox :: Menus, enhancement, P1)

Desktop
All
enhancement

Tracking

()

VERIFIED FIXED
88 Branch
Tracking Status
firefox88 --- verified

People

(Reporter: Gijs, Assigned: ewright)

References

(Blocks 1 open bug)

Details

(Keywords: helpwanted, Whiteboard: [proton-context-menus])

Attachments

(1 file)

This item shows up on links and for text selections.

In both cases, it's pretty different from the items before and after it, and shouldn't be grouped together with them.

Neil's patch in https://phabricator.services.mozilla.com/D104615 / bug 1691860 should be able to help with this.

Small addendum: if we show "Add Keyword for this search", it should appear in the same group. But it shouldn't be lumped together with "This Frame", "Copy Link Location", or anything else like that.

Keywords: helpwanted
Priority: P3 → P2
Assignee: nobody → ewright
Status: NEW → ASSIGNED
Attachment #9206987 - Attachment description: Bug 1692666 - Move 'Search... for...' to a dedicated sectiion. → Bug 1692666 - Move 'Search... for...' to a dedicated section.
Blocks: 1696574
Priority: P2 → P1
Pushed by ewright@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5b20ddb7ad97
Move 'Search... for...' to a dedicated section. r=Gijs
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch

Verified that Search [Engine] for '... is now moved in its own section in page context menu and its functionality is working as expected for multiple search engines. For input fields with text, Search [Engine] for... is be in the same group as Add Keyword for this search but not with This Frame or any other input. Verified using latest Nightly 88.0a1 across platforms (Windows 10, Ubuntu 18.04 and macOS 11.3).

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: