1696574 - Adjust "print selection" to come directly after "select all" before the separator with "search [search engine] for..."

Status: VERIFIED FIXED

(Firefox :: Menus, defect, P2)

Description

[:Gijs (he/him)]

In bug 1692628 the "view selection source" item is moving to live with "view page source" and the 1/2 inspect item(s).

In bug 1692666, we're making sure the "search [engine] for ..." is in its own little group with a separator above and below.

There appears, from https://docs.google.com/presentation/d/1Ufd0A3HsziyXXAjXYNH84P2bu7RdTxARsA0xpKmwIWs/edit?ts=6011b061#slide=id.gbcc1627a53_1_25 , to be one more change we want to make, which is to move "print selection" to come after "select all" and before "take a screenshot", with no separator between copy/select all/print selection/take screenshot, and then a separator before the "search [engine]" item.

I apologize for the fact that between bug 1692666, bug 1692628, and bug 1690585 this is all over similar bits of the context menu code, and so updating tests and/or ordering landings might be a bit tricky... It may be worth syncing up briefly next week to figure out which of those land in which order to avoid lost time with repeated rebases etc.

Comment 1

[Michelle Goossens [:masterwayz]]

Attachment: Bug 1696574 - Adjust "print selection" to come directly after "select all" before the separator with "search [search engine] for..." r?emalysz

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3813a83e0edd
Adjust "print selection" to come directly after "select all" before the separator with "search [search engine] for..." r=Gijs

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/3813a83e0edd

Comment 4

[Bogdan Maris, Desktop Test Engineering]

Verified that Print selection options is located directly after Select all before the separator with Search [search engine] for... using latest Nightly 88.0a1 across platforms (Windows 10, Ubuntu 18.04 and macOS 11.3).