Closed Bug 1692667 Opened 10 months ago Closed 9 months ago

Update labeling and ordering of the tabstrip context menu

Categories

(Firefox :: Menus, enhancement, P1)

Desktop
All
enhancement

Tracking

()

VERIFIED FIXED
88 Branch
Tracking Status
firefox88 --- verified

People

(Reporter: Gijs, Assigned: jaws)

References

(Blocks 1 open bug)

Details

(Keywords: helpwanted, Whiteboard: [proton-context-menus])

Attachments

(2 files)

The preferred order UX has determined here is:

Bookmark Tab
Move Tab >
Send Tab to Device   >
Share  > 
Open in New Container >
Select All Tabs
--
Close Tab
Close Multiple Tabs >
Reopen Closed Tab

Note also the changed labels for Reopen in Container and Undo Close Tab.

The Share item is being added in bug 1690569.

Keywords: helpwanted
Assignee: nobody → jaws
Status: NEW → ASSIGNED

As per guidance from Vicky, for tracking, we're marking all the bugs that people are working on as P1.

Priority: P3 → P1

The top of the menu is staying the same, ie:

Reload Tab
Mute / Unmute Tab
Pin / Unpin Tab
Duplicate Tab
--

we're also adding an "Open a New Tab" item in bug 1692840

See Also: → 1692840
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e6c54b6ab46d
Update labeling and ordering of the tabstrip context menu. r=Gijs
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch

"Open in New Container" doesn't make much sense to me - it's not a new container. I have four global containers, this opens in one of them. It doesn't add one.

(In reply to Markus Stange [:mstange] from comment #6)

"Open in New Container" doesn't make much sense to me - it's not a new container. I have four global containers, this opens in one of them. It doesn't add one.

Would "Open in New Container Tab" be an improvement?

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #7)

(In reply to Markus Stange [:mstange] from comment #6)

"Open in New Container" doesn't make much sense to me - it's not a new container. I have four global containers, this opens in one of them. It doesn't add one.

Would "Open in New Container Tab" be an improvement?

That's what it was before, right? Feels like this is a discussion that needs to happen with the UX folks who made the content decisions here. Note that the language matches the content context menu so if we do decide to use something else, both need updating. Meridel, can you take a look?

Flags: needinfo?(mwalkington)

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #7)

Would "Open in New Container Tab" be an improvement?

Yes, that sounds good!

(In reply to :Gijs (he/him) from comment #8)

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #7)

Would "Open in New Container Tab" be an improvement?

That's what it was before, right?

It was "Reopen in Container" before.

(In reply to Markus Stange [:mstange] from comment #9)

(In reply to :Gijs (he/him) from comment #8)
It was "Reopen in Container" before.

Sorry, yes, in the tab context menu which this bug is about - I got muddled because in the content context menu for links we made a change towards the same string ("Open in New Container"), and that one was "Open in New Container Tab" before.

Thanks for flagging this for me. We'd made the change to "Open in New Container" to simplify the string.

I've since learned some more about how we are using containers, and latest direction from PM (on the panels work) was to leave container items as-is. So, to avoid introducing potential confusion, AND to be consistent, let's do minimal changes and standardize to "Open Link in New Container Tab" in all three context menus where this string appears.

(The screenshot is documented on slide 106 in the Menus deck).

Flags: needinfo?(mwalkington)
Blocks: 1697682

(In reply to Meridel [:meridel] from comment #11)

OK, I've filed bug 1697682 for this change.

Verified that the changes mentioned in comment 0 (The change for Open in New Container will be verified in bug 1697682) and comment 2 are indeed reflected in Latest Nightly 88.0a1 across platforms (Windows 10, macOS 11.3 and Ubuntu 18.04 (without Share) ) and their functionality is not affected. Removing firefox87 flag since this was targeted for Firefox 88.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.