1697682 - Update container-related content and tab context menu labels, take 2

Status: VERIFIED FIXED

(Firefox :: Menus, defect, P2)

Description

[:Gijs (out for now; he/him)]

See bug 1692667 comment 11.

This should update both https://searchfox.org/mozilla-central/rev/ca910762568921c0faa34838d6a4efac2471dff1/browser/base/content/browser.xhtml#182-184 and https://searchfox.org/mozilla-central/rev/ca910762568921c0faa34838d6a4efac2471dff1/browser/base/content/browser-context.inc#70-72 to the same label

:flod, I think because bug 1690561 landed recently and for the link/image-link context menu this is a revert, we can just change it back to the previous string ID and value, right? For the tab context menu, I think we'll need another new string, unfortunately... Can you confirm?

Comment 1

[:Gijs (out for now; he/him)]

(In reply to :Gijs (he/him) from comment #0)

For the tab context menu, I think we'll need another new string, unfortunately... Can you confirm?

(to be clear, we cannot share the same string because the access key may need to be different in different context menus, even if this may or may not be the case in English)

Comment 2

[Francesco Lodolo [:flod]]

(In reply to :Gijs (he/him) from comment #0)

:flod, I think because bug 1690561 landed recently and for the link/image-link context menu this is a revert, we can just change it back to the previous string ID and value, right? For the tab context menu, I think we'll need another new string, unfortunately... Can you confirm?

Yes, that's correct.

We can revert back to main-context-menu-open-link-container-tab, but we need a new string for the tab context, since the current one was newly introduced in bug 1692667.

Comment 3

[Florian Quèze [:florian]]

Attachment: Bug 1697682 - Update container-related content and tab context menu labels to 'Open Link in New Container Tab' and 'Open in New Container Tab', r=Gijs.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5fde54b1934f
Update container-related content and tab context menu labels to both use the same 'Open Link in New Container Tab' wording, r=fluent-reviewers,flod.

Comment 5

[Sandor Molnar[:smolnar]]

Backed out for causing browser-chrome failures in browser_contextmenu

Backout link: https://hg.mozilla.org/integration/autoland/rev/6b1c4e0357120da6afd9aa7c7f3da710117e3756

Push with failures

Failure log

INFO - Buffered messages finished
[task 2021-03-12T17:12:11.448Z] 17:12:11 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/contextMenu/browser_contextmenu.js | menuitem context-bookmarklink has same accesskey as context-openlinkinusercontext-menu -
[task 2021-03-12T17:12:11.449Z] 17:12:11 INFO - Stack trace:
[task 2021-03-12T17:12:11.449Z] 17:12:11 INFO - chrome://mochikit/content/browser-test.js:test_ok:1331
[task 2021-03-12T17:12:11.449Z] 17:12:11 INFO - chrome://mochitests/content/browser/browser/base/content/test/contextMenu/contextmenu_common.js:getVisibleMenuItems:95
[task 2021-03-12T17:12:11.449Z] 17:12:11 INFO - chrome://mochitests/content/browser/browser/base/content/test/contextMenu/contextmenu_common.js:checkMenu:263
[task 2021-03-12T17:12:11.450Z] 17:12:11 INFO - chrome://mochitests/content/browser/browser/base/content/test/contextMenu/contextmenu_common.js:checkContextMenu:175
[task 2021-03-12T17:12:11.450Z] 17:12:11 INFO - chrome://mochitests/content/browser/browser/base/content/test/contextMenu/contextmenu_common.js:test_contextmenu:444

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ef9c3f2a2544
Update container-related content and tab context menu labels to 'Open Link in New Container Tab' and 'Open in New Container Tab', r=fluent-reviewers,flod.

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/ef9c3f2a2544

Comment 8

[Bogdan Maris, Desktop Test Engineering]

Verified that Open in New Container and Open Link in New Container are now changed to Open Link in New Container Tab and Open in New Container Tab in Latest Nightly 88.0a1 across platforms (Windows 10, Ubuntu 18.04 and macOS 11.3).