1692975 - browser is undefined in tab options page

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, defect)

Description

[John Bieling (:TbSync)]

This seems unrelated to e10s, at least behavior does not change if browser.tabs.remote.autostart is disabled.

Comment 1

[Mark Banner (:standard8)]

This was working for Conversations in 86.0b1, but has broken again in 86.0b3 (the original bug that fixed this being bug 1688474).

Comment 2

[John Bieling (:TbSync)]

It looks like the fix was a general fix for tabs? Tabs still work in 86.0b3, just not the options tab.

Comment 3

[Mark Banner (:standard8)]

I'm not sure, it was unclear to me exactly how that fixed things and if it was just limited to options or not.

Comment 4

[John Bieling (:TbSync)]

Geoff, could you have a look, or point me to where to start looking?

Comment 5

[Rob Lemley [:rjl]]

The options page worked in 86.0b1 and broke in 86.0b2.

With that info, I ran mozregression against nightly on the date range Jan 25 - Feb 8 which was the dates between beta 1 and beta 2. The theory being that whatever we uplifted in beta 2 that broke the options page would have landed on c-central during that time period.

The narrowed things down to this push: https://hg.mozilla.org/comm-central/pushloghtml?changeset=7f4a02e02f8c87b726e68de9197320764ec57fe5 where the options page broke on Nightly.

Looking at the bugs in that push vs the bugs uplifted to beta 2 gives these bug numbers:

1681887 - Intermittent comm/mail/test/browser/openpgp/browser_viewMessage.js | Secret text should be contained in message - chrome://mochitests/content/browser/comm/mail/test/browser/openpgp/browser_viewMessage.js :: testDecryptInlineWithNBSPasQP :: line 400
1685918 - CalDav New Event Naming: Loss-of-focus after click-and-drag creation
1687847 - Image attachments loaded in message reader pane instead of opened
1690176 - about: pages can't link to web pages (after tb-fission)

So of those, I guessed that bug 1690176 was the culprit. I ran a local build with the current comm-central tree to verify that the options page is still broken there. It is. Then I backed out rev 7f4a02e02f8c from bug 1690176 and ran mach build faster. The options page worked when I ran the result.

Comment 6

[Geoff Lankow (:darktrojan)]

Bah! Found it.

Comment 7

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1692975 - Always open moz-extension: pages in the "browsers" message manager group. r?mkmelin

Having add-on options pages open in the default "single-site" group is somehow preventing them from accessing the WebExtension browser object.

Also I've fixed switchToTabHavingURI to pass on all parameters to openTab as the Firefox version does. It wasn't the cause of this bug but it needed to be fixed regardless.

Comment 8

[Rob Lemley [:rjl]]

I applied the patch locally and ran a build (comm-central). Success!

I also applied the patch to 87.0b1 and verified it fixes the issue there as well. Please uplift. :)

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ef48ca6dd9b0
Always open moz-extension: pages in the "browsers" message manager group. r=mkmelin

Comment 10

[Geoff Lankow (:darktrojan)]

Comment on attachment 9205056 [details]
Bug 1692975 - Always open moz-extension: pages in the "browsers" message manager group. r?mkmelin

[Approval Request Comment]
Regression caused by (bug #): bug 1690176
User impact if declined: extension options pages don't work at all in a tab
Testing completed (on c-c, etc.): Rob says it works! Also it just landed
Risk to taking this patch (and alternatives if risky): nope

Comment 11

[C-E]

I just tested my Add-ons "Textmarker" Version 5.1.0 and "StandardTexter" Version 1.0.3 with TB87.0b1.
Both Add-ons use options.html in a tab, and both are not working correctly.
browser is undefined in options.js
chrome is undefined in l10n.js

Comment 12

[Rob Lemley [:rjl]]

The fix is not included in 87.0beta1. What I refer to in comment 8 is a test I did with a local build.

Comment 13

[C-E]

Ah okay, then I misunderstood this.
Do I understand right that "Milestone:88 Branch" means that this issue will be fixed in version 88?

Comment 14

[Rob Lemley [:rjl]]

Yes, but uplift to 87beta was requested. Unless a problem comes up, it will likely be fixed in 87.0beta2.

Comment 15

[Wayne Mery (:wsmwk)]

Comment on attachment 9205056 [details]
Bug 1692975 - Always open moz-extension: pages in the "browsers" message manager group. r?mkmelin

[Triage Comment]
approved for beta

Comment 16

[Rob Lemley [:rjl]]

Thunderbird 87.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/bb278641e073