1693133 - Update refresh Firefox dialog for Proton

Status: VERIFIED FIXED

(Toolkit Graveyard :: Notifications and Alerts, enhancement, P2)

Description

[:Gijs (he/him)]

This is https://searchfox.org/mozilla-central/source/toolkit/content/resetProfile.xhtml .

The title should be:

Refresh {Brand name} to its default settings?

The content should be:

Start fresh to fix performance issues. This will remove your extensions and customizations. You won’t lose essential information like bookmarks and passwords.

Learn more

Where the last link points to SUMO. (TBD if we use the same hardcoding system url bar interventions or if we ask SUMO to create a redirect, see question in bug 1606917)

The dialog should show as a modern window-modal dialog (not a macOS sheet or a separate window on Windows/Linux).

The buttons stay the same in terms of text/content, but the refresh button should get the "error button" component styling (red with white text).

Comment 1

[:Gijs (he/him)]

Update priority to reflect proton priorities.

Comment 2

[Alex Thayer [:alexical] (she/her)]

Attachment: Bug 1693133 - Update refresh Firefox dialog for Proton r?Gijs

Comment 3

[Alex Thayer [:alexical] (she/her)]

Attachment: Bug 1693133 - Fix resetProfile.xhtml tests r?Gijs

BrowserTestUtils.promiseAlertDialog and friends account for commonDialog.xhtml,
but not other dialogs which go through gDialogBox. This fixes that by adding a
inWindowDialog option to promiseAlertDialog. I don't like this solution very
much - it requires all of these dialogs to fire the event themselves. An
alternative might be putting this code in some file which these all include,
but given how small the code is that feels like overkill. Alternatives welcome.

Depends on D109452

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b9988582fc78
Update refresh Firefox dialog for Proton r=Gijs
https://hg.mozilla.org/integration/autoland/rev/b9a9540d4eee
Fix resetProfile.xhtml tests r=Gijs

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/b9988582fc78
https://hg.mozilla.org/mozilla-central/rev/b9a9540d4eee

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/85f7d9b4fce0
Port bug 1693133 - Changes to BrowserTestUtils.promiseAlertDialog and promiseAlertDialogOpen. rs=bustage-fix

Comment 8

[Rares Doghi, Desktop QA]

This issue is Verified as fixed in our latest Nightly and Beta 89.0b3.