1606917 - Port the Interventions experiment into a new provider

Status: RESOLVED FIXED

(Firefox :: Address Bar, enhancement, P2)

Comment 1

[Harry Twyford]

I think it will be easier to do this in one patch, rather than porting Interventions then adding the Update (bug 1606918) and Refresh (bug 1606919) interventions separately. I'm going to close those bugs and bump the points on this one.

Comment 2

[Harry Twyford]

Attachment: Bug 1606917 - Port the Interventions experiment into a new provider.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4f83b17d63bf
Port the Interventions experiment into a new provider. r=adw,fluent-reviewers,Pike

Comment 4

[Harry Twyford]

Attachment: Bug 1606917 - Cleanup - Port the Interventions experiment into a new provider. r?adw!

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/4f83b17d63bf

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/391df9744258
Cleanup - Port the Interventions experiment into a new provider. r=adw

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/391df9744258

Comment 8

[Alexandru Ionescu (needinfo me) [:alexandrui]]

== Change summary for alert #24884 (as of Fri, 07 Feb 2020 08:36:02 GMT) ==

Improvements:

2% sessionrestore linux64-shippable opt e10s stylo 576.46 -> 562.42
2% startup_about_home_paint linux64-shippable opt e10s stylo 804.92 -> 787.58

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=24884

Comment 9

[:Gijs (he/him)]

Was there a particular reason to hardcode the sumo links here rather than using the baseURL method with Services.urlFormatter.formatURLPref to get version+locale appropriate SUMO redirects?

Comment 10

[Harry Twyford]

There was not. Should I file a folllow-up, or has this come up in a patch you're already working on?

Comment 11

[:Gijs (he/him)]

(In reply to Harry Twyford [:harry] from comment #10)

There was not. Should I file a folllow-up, or has this come up in a patch you're already working on?

It's coming up in bug 1693133 because we need a SUMO link there and I thought I'd use the same one that this code used, but then it turned out it wasn't using one. Normally we have to ask the SUMO folks to create a redirect if one doesn't exist, but I don't know if there is one already or not. If you would file a follow-up bug blocking this and bug 1693133 and needinfo Joni (jsavage@) to check what does and doesn't exist already, that would be great. I also don't know if we want different ones per feature to work out where traffic comes from... Again, hopefully they know what to do there...

Comment 12

[Drew Willcoxon :adw]

Sorry for not catching that in review.