1701277 - "Remove" button in the remove logins dialog has low contrast/wrong color

Status: RESOLVED DUPLICATE of bug 1699250

(Firefox :: about:logins, defect, P2)

Description

[Tim Giles [:tgiles]]

Attachment: thumbnail.png

The "remove" button in the remove login dialog has low contrast and/or the wrong color given OS dark theme and Firefox dark theme.

Edit: originally I thought this was only present when the Proton pref was enabled, but is currently present in Nightly.

Comment 1

[Tim Giles [:tgiles]]

Bug 1699250 may fix this issue, so we should wait until that lands and verify if this is still a valid bug

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1693133

Comment 3

[Sam Foster [:sfoster] (he/him)]

We shouldn't be shipping UI that isn't accessible, so I'm calling this P2.

Comment 4

[Pascal Chevrel:pascalc (PTO until April 26)]

Tim, did the bug fix in bug 1699250 fix this issue?

Comment 5

[Tim Giles [:tgiles]]

Pascal, unfortunately no, the fix for bug 1699250 did not fix this issue.

Comment 6

[Pascal Chevrel:pascalc (PTO until April 26)]

Sam, is that something we should care about for a fix in 89?

Comment 7

[Sam Foster [:sfoster] (he/him)]

(In reply to Pascal Chevrel:pascalc from comment #6)

Sam, is that something we should care about for a fix in 89?

Yes, I think this is a pretty trivial fix and would be good to get into 89.

Comment 8

[Pascal Chevrel:pascalc (PTO until April 26)]

Tracking for a potential uplift in 89, thanks.

Comment 9

[Dimi Lee [:dimi]]

Attachment: thumbnail0420.png

The text is changed to black after this patch was landed, so this is fixed by Bug 1699250.

Comment 11

[Dimi Lee [:dimi]]

update the tracking flags

Comment 12

[Simona Rosu [:srosu], Ecosystem QA]

I have verified this issue using the latest Nightly 90.0a1 (Build ID: 20210506214311) and Firefox Beta 89.0b9 (Build ID: 20210506185706) on Windows 10 x64, Ubuntu 20.04 and macOS 11.2.3.

• The text of the “Remove” button is changed to black and the contrast of the button is more intense.