1693167 - Context menu "Copy Email Address" sometimes requires two "Copy Email Address" actions to properly copy the wanted email address

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Arthur K. (he/him)]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0

Steps to reproduce:

I received an email and right-clicked the From: email address and chose "Copy Email Address" from the context menu.

Actual results:

When I paste the copied email address, it is the email address from two copy actions ago. It doesn't repro 100% of the time but often with a newly arrived email. I mostly see this when I am writing an abuse report and a spammer will 1) send From: [e-mail], 2) Reply-To: is [e-mail]. I usually alt-tab back to the email to copy out the spammer's info. That mainly when it happens.

Expected results:

Shouldn't remember any previous emails in the clipboard after a "Copy Email Address" action.

Comment 1

[Arthur K. (he/him)]

Ok, I managed to catch it in the act and had Error Console Open as well. This is what I got. Hope it's useful.

15:27:23.770 Uncaught TypeError: emailAddressNode is null
setupEmailAddressPopup chrome://messenger/content/msgHdrView.js:1635
onpopupshowing chrome://messenger/content/messenger.xhtml:1
msgHdrView.js:1635:3

15:27:25.020
Uncaught TypeError: addressNode is null
CopyEmailNewsAddress chrome://messenger/content/msgHdrView.js:1812
oncommand chrome://messenger/content/messenger.xhtml:1
msgHdrView.js:1812:5

15:27:25.020
Uncaught TypeError: addressNode is null
hideEmailNewsPopup chrome://messenger/content/msgHdrView.js:1630
onpopuphiding chrome://messenger/content/messenger.xhtml:1
msgHdrView.js:1630

Comment 2

[Arthur K. (he/him)]

Just playing with the 1st beta build of 89.0. Still present.

14:38:14.954 Uncaught TypeError: emailAddressNode is null msgHdrView.js:1636:3
setupEmailAddressPopup chrome://messenger/content/msgHdrView.js:1636
onpopupshowing chrome://messenger/content/messenger.xhtml:1

14:38:16.720
Uncaught TypeError: addressNode is null msgHdrView.js:1813:5
CopyEmailNewsAddress chrome://messenger/content/msgHdrView.js:1813
oncommand chrome://messenger/content/messenger.xhtml:1

14:38:16.720
Uncaught TypeError: addressNode is nul l msgHdrView.js:1631:3
hideEmailNewsPopup chrome://messenger/content/msgHdrView.js:1631
onpopuphiding chrome://messenger/content/messenger.xhtml:1

Comment 3

[Ellis]

We have about 10 users of Thunderbird and we've all been having the same issue, seemingly, for months if not years.

We're currently all running the latest stable release:
78.10.0

Please fix as it's really irritating!

Comment 4

[Wayne Mery (:wsmwk)]

Thomas, does comment 1 + 2 provide blame?

Comment 5

[Arthur K. (he/him)]

(In reply to Ellis from comment #3)

We have about 10 users of Thunderbird and we've all been having the same issue, seemingly, for months if not years.

We're currently all running the latest stable release:
78.10.0

Please fix as it's really irritating!

I never observed this in the early 78.x releases and seems this has only recently crept into the post 78.x TB betas (maybe around 84-85?).

On an affected machine using 78, can you:

1. CTRL-Shift-J to open Error Console
2. In Error Console, click the trash can icon at top-left to clear the screen
3. Go back to an email and right-click to copy email address
4. Go back to Error Console and see if it's throwing the same error as in comment 1 or comment 2

Comment 6

[Thomas D. (:thomas8)]

I am failing to reproduce this bug on any of 78.10.0 (32-bit), 89.0b1 (64-Bit), 90.0a1 (2021-04-28) (64-bit).

(In reply to Wayne Mery (:wsmwk) from comment #4)

Thomas, does comment 1 + 2 provide blame?

Nothing which would explain this bug. All of the blames are very old or just reformatting.

https://searchfox.org/comm-central/rev/ed09a085f3b74782be51dd96f5e7a4c61a1f7a2b/mail/base/content/msgHdrView.js#1636
https://searchfox.org/comm-central/rev/ed09a085f3b74782be51dd96f5e7a4c61a1f7a2b/mail/base/content/msgHdrView.js#1813
https://searchfox.org/comm-central/rev/ed09a085f3b74782be51dd96f5e7a4c61a1f7a2b/mail/base/content/msgHdrView.js#1631

Note that the actual lines where the error occurs must be a few lines off.
The common denominator is that they are all passing document.popupNode into a function, and if that's undefined, obviously some of the subsequent lines e.g. having popupNode.closest will fail. Why or how document.popupNode would be undefined for right-click is a mystery to me, so I think this involves other factors like addons, assistive technologies, or missing steps.

Comment 7

[Magnus Melin [:mkmelin]]

I can reproduce, but only randomly.
It's possible replacing the deprecated document.popupNode with event.target.triggerNode would fix it.

Comment 8

[Arthur K. (he/him)]

In testing with 91.0b3, this doesn't seem to be happening anymore. I am saying this with cautious optimism. I'll keep testing. As it gets closer to 91.0ESR, I'll keep trying to repro and follow up if I feel like it's no longer happening.

Comment 9

[Magnus Melin [:mkmelin]]

Yes comment 7 was fixed in bug 1719985.